You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/10 20:11:48 UTC
[GitHub] [incubator-mxnet] MoisesHer opened a new pull request #18023: GPU
gemms true fp16 (#17466)
MoisesHer opened a new pull request #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023
* Temporal solution for fp16 accumulation in Bert gemms
* Resolve alpha/beta type issue
* add documentation for env variable MXNET_FC_TRUE_FP16
* Improve description of env variable
* Add unitest checking environment variable
* keep pseudo-fp16 if architecture does not support Float16Compute
* Fix cpplint
## Description ##
This PR allows true FP16 in CUBLAS gemms if environment variable MXNET_FC_TRUE_FP16 is set to true
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator):
tests/python/gpu/test_gluon_gpu:test_gemms_true_fp16
- [x] Code is well-documented:
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] General half_precision Gemm: allows true fp16 if MXNET_FC_TRUE_FP16 is set
- [x] Transformer: allows true fp16 if MXNET_FC_TRUE_FP16 is set
## Comments ##
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] MoisesHer commented on issue #18023: GPU gemms
true fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
MoisesHer commented on issue #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023#issuecomment-613698911
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18023: GPU gemms
true fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023#issuecomment-613699003
Jenkins CI successfully triggered : [sanity, windows-gpu, edge, unix-cpu, miscellaneous, unix-gpu, website, centos-cpu, windows-cpu, clang, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18023: GPU gemms
true fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023#issuecomment-612197337
Hey @MoisesHer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, miscellaneous, edge, unix-cpu, windows-gpu, centos-gpu, centos-cpu, windows-cpu, website, clang, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #18023: GPU gemms true
fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023#issuecomment-612521312
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18023: GPU gemms
true fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023#issuecomment-612521337
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ciyongch commented on issue #18023: GPU gemms
true fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023#issuecomment-612306993
Adding this to 1.7.0 roadmap https://github.com/apache/incubator-mxnet/issues/16864.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx merged pull request #18023: GPU gemms
true fp16 (#17466)
Posted by GitBox <gi...@apache.org>.
ptrendx merged pull request #18023: GPU gemms true fp16 (#17466)
URL: https://github.com/apache/incubator-mxnet/pull/18023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services