You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/11/14 22:25:39 UTC

[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14707

to look at the new patch set (#4).

Change subject: IMPALA-9081: fix mt_dop validation tests
......................................................................

IMPALA-9081: fix mt_dop validation tests

This undoes the hack of pretending that it's not a test environment for
that single test. That had side effects, e.g. for the metadata loading
path.

Instead we have a special flag to enable the validation code in
frontend tests.

Note that the plans change to include join build sinks as an
expected result of undoing the hack.

Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f
---
M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation-hdfs-num-rows-est-enabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test
5 files changed, 88 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/14707/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f
Gerrit-Change-Number: 14707
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>