You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/06/12 00:30:29 UTC

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5544: Add SCALAR type into TransformFunctionType

Jackie-Jiang opened a new pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544


   ## Description
   Inside query engine, scalar function is modeled as TransformFunction (ScalarTransformFunctionWrapper)
   Add SCALAR type into TransformFunctionType so that FunctionDefinitionRegistry can identify scalar function as transform function


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#issuecomment-643034473


   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@f1f1c41`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5544/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5544   +/-   ##
   =========================================
     Coverage          ?   66.52%           
   =========================================
     Files             ?     1104           
     Lines             ?    56874           
     Branches          ?     8506           
   =========================================
     Hits              ?    37833           
     Misses            ?    16238           
     Partials          ?     2803           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `45.08% <50.00%> (?)` | |
   | #unittests | `56.86% <75.00%> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `88.88% <75.00%> (ø)` | |
   | [...ot/core/operator/query/EmptySelectionOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9FbXB0eVNlbGVjdGlvbk9wZXJhdG9yLmphdmE=) | `94.44% <0.00%> (ø)` | |
   | [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...he/pinot/core/query/reduce/ComparisonFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQ29tcGFyaXNvbkZ1bmN0aW9uLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...he/pinot/controller/api/resources/HeaderAdder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0hlYWRlckFkZGVyLmphdmE=) | `71.87% <0.00%> (ø)` | |
   | [.../org/apache/pinot/core/minion/PinotTaskConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vUGlub3RUYXNrQ29uZmlnLmphdmE=) | `54.54% <0.00%> (ø)` | |
   | [...t/spi/utils/retry/RetriableOperationException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvcmV0cnkvUmV0cmlhYmxlT3BlcmF0aW9uRXhjZXB0aW9uLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...ache/pinot/common/response/broker/ResultTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL1Jlc3VsdFRhYmxlLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...helix/PinotHelixPropertyStoreZnRecordProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvUGlub3RIZWxpeFByb3BlcnR5U3RvcmVablJlY29yZFByb3ZpZGVyLmphdmE=) | `43.75% <0.00%> (ø)` | |
   | ... and [1095 more](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=footer). Last update [f1f1c41...cc80829](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439587265



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
##########
@@ -70,6 +73,9 @@ public static TransformFunctionType getTransformFunctionType(String functionName
     try {
       return TransformFunctionType.valueOf(upperCaseFunctionName);
     } catch (Exception e) {
+      if (FunctionRegistry.getFunctionByName(functionName) != null) {

Review comment:
       Awesome. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439497342



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
##########
@@ -70,6 +73,9 @@ public static TransformFunctionType getTransformFunctionType(String functionName
     try {
       return TransformFunctionType.valueOf(upperCaseFunctionName);
     } catch (Exception e) {
+      if (FunctionRegistry.getFunctionByName(functionName) != null) {

Review comment:
       This looks a bit hacky especially if FunctionRegistry starts getting used for something else as well (in addition to scalar functions). May be update the Javadoc of FunctionRegistry to state it is for scalar functions?
   
   Currently it says in-built Pinot functions which is misleading since today all functions are in-built functions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#issuecomment-643034473


   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@f1f1c41`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5544/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5544   +/-   ##
   =========================================
     Coverage          ?   66.29%           
   =========================================
     Files             ?     1105           
     Lines             ?    56877           
     Branches          ?     8506           
   =========================================
     Hits              ?    37709           
     Misses            ?    16378           
     Partials          ?     2790           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.88% <50.00%> (?)` | |
   | #unittests | `56.79% <75.00%> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apache/pinot/common/function/FunctionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25SZWdpc3RyeS5qYXZh) | `82.14% <ø> (ø)` | |
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `88.88% <75.00%> (ø)` | |
   | [...rm/transformer/datetime/SDFToEpochTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vdHJhbnNmb3JtZXIvZGF0ZXRpbWUvU0RGVG9FcG9jaFRyYW5zZm9ybWVyLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...org/apache/pinot/core/plan/ProjectionPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1Byb2plY3Rpb25QbGFuTm9kZS5qYXZh) | `61.11% <0.00%> (ø)` | |
   | [...ot/core/segment/index/readers/BytesDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvQnl0ZXNEaWN0aW9uYXJ5LmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...gin/inputformat/avro/SimpleAvroMessageDecoder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L2F2cm8vU2ltcGxlQXZyb01lc3NhZ2VEZWNvZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...g/apache/pinot/core/common/DataSourceMetadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZU1ldGFkYXRhLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [.../apache/pinot/controller/util/TableSizeReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1RhYmxlU2l6ZVJlYWRlci5qYXZh) | `96.15% <0.00%> (ø)` | |
   | [...ment/index/readers/text/LuceneTextIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvdGV4dC9MdWNlbmVUZXh0SW5kZXhSZWFkZXIuamF2YQ==) | `76.78% <0.00%> (ø)` | |
   | ... and [1097 more](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=footer). Last update [f1f1c41...e085cfe](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#issuecomment-643034473


   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@f1f1c41`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5544/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5544   +/-   ##
   =========================================
     Coverage          ?   66.52%           
   =========================================
     Files             ?     1104           
     Lines             ?    56874           
     Branches          ?     8506           
   =========================================
     Hits              ?    37833           
     Misses            ?    16238           
     Partials          ?     2803           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `45.08% <50.00%> (?)` | |
   | #unittests | `56.83% <75.00%> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `88.88% <75.00%> (ø)` | |
   | [...ot/core/indexsegment/generator/SegmentVersion.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvZ2VuZXJhdG9yL1NlZ21lbnRWZXJzaW9uLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `82.81% <0.00%> (ø)` | |
   | [...pinot/minion/executor/SegmentConversionResult.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvU2VnbWVudENvbnZlcnNpb25SZXN1bHQuamF2YQ==) | `90.47% <0.00%> (ø)` | |
   | [...writer/BaseSingleColumnMultiValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvQmFzZVNpbmdsZUNvbHVtbk11bHRpVmFsdWVSZWFkZXJXcml0ZXIuamF2YQ==) | `15.78% <0.00%> (ø)` | |
   | [...he/pinot/common/messages/SegmentReloadMessage.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvU2VnbWVudFJlbG9hZE1lc3NhZ2UuamF2YQ==) | `81.81% <0.00%> (ø)` | |
   | [...roller/api/resources/PinotTaskRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGFza1Jlc3RsZXRSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...main/java/org/apache/pinot/core/util/SizeUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NpemVVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/pinot/core/util/SchemaUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NjaGVtYVV0aWxzLmphdmE=) | `88.09% <0.00%> (ø)` | |
   | [...loader/defaultcolumn/BaseDefaultColumnHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9kZWZhdWx0Y29sdW1uL0Jhc2VEZWZhdWx0Q29sdW1uSGFuZGxlci5qYXZh) | `81.94% <0.00%> (ø)` | |
   | ... and [1095 more](https://codecov.io/gh/apache/incubator-pinot/pull/5544/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=footer). Last update [f1f1c41...cc80829](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439567697



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
##########
@@ -70,6 +73,9 @@ public static TransformFunctionType getTransformFunctionType(String functionName
     try {
       return TransformFunctionType.valueOf(upperCaseFunctionName);
     } catch (Exception e) {
+      if (FunctionRegistry.getFunctionByName(functionName) != null) {

Review comment:
       @siddharthteotia Updated the doc, and also added a TODO to merge FunctionRegistry and FunctionDefinitionRegistry to provide one single registry for all functions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org