You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "harinreddy (Code Review)" <ge...@cloudera.org> on 2022/09/19 03:31:57 UTC
[kudu-CR] Adds opname test for ‘blr” for ppc64le architecture
harinreddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19015
Change subject: Adds opname test for ‘blr” for ppc64le architecture
......................................................................
Adds opname test for ‘blr” for ppc64le architecture
ppc64le does not have the assembler instruction “ret" or "retq".
The quivalent opcode for ppc64le architecture is "blr".
Changes to be committed:
modified: src/kudu/codegen/codegen-test.cc
Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
---
M src/kudu/codegen/codegen-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19015/1
--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
[kudu-CR] [codegen] update CodegenTest.TestDumpMC for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by harinreddy. ( http://gerrit.cloudera.org:8080/19015 )
Change subject: [codegen] update CodegenTest.TestDumpMC for ppc64le
......................................................................
[codegen] update CodegenTest.TestDumpMC for ppc64le
The equivalent of x86_64's "retq" assembler instruction on ppc64le
is "blr".
Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
---
M src/kudu/codegen/codegen-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19015/2
--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [codegen] update CodegenTest.TestDumpMC for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19015 )
Change subject: [codegen] update CodegenTest.TestDumpMC for ppc64le
......................................................................
[codegen] update CodegenTest.TestDumpMC for ppc64le
The equivalent of x86_64's "retq" assembler instruction on ppc64le
is "blr".
Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Reviewed-on: http://gerrit.cloudera.org:8080/19015
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/codegen/codegen-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 3
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [codegen] update CodegenTest.TestDumpMC for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19015 )
Change subject: [codegen] update CodegenTest.TestDumpMC for ppc64le
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jan 2023 06:15:45 +0000
Gerrit-HasComments: No