[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #814: Implement Byte Insertion Keybinds Hotfix

["stricklandrbls (via GitHub)" <gi...@apache.org>]

stricklandrbls commented on code in PR #814:
URL: https://github.com/apache/daffodil-vscode/pull/814#discussion_r1294949787


##########
src/svelte/src/utilities/elementKeypressEvents.ts:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+type ElementKeypressEventKey = 'Enter' | 'Delete'
+const MappableKeys: { [k in ElementKeypressEventKey]: true } = {
+  Enter: true,
+  Delete: true,
+}

Review Comment:
   @scholarsmate I was going to make it completely generic but left it as `Enter` and `Delete` only as I wasn't sure if we wanted to ability to make _all_ keys mappable. 
   
   I guess it doesn't matter much though, outside of the conditional in `dataEditor.svelte` where it checks if any key that triggers the event is a mappable key.
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org