You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2026/08/13 11:58:03 UTC

[PR] test(flink): stabilize Sink V2 UID assertion [hudi]

danny0405 opened a new pull request, #19623:
URL: https://github.com/apache/hudi/pull/19623

   ### Describe the issue this Pull Request addresses
   
   `TestPipelinesV2#testSinkUsesModeSpecificParallelismAndStableIdentity` assumes that the first Sink V2 operator created in a shared test JVM has no numeric UID suffix. `Pipelines.opUID` intentionally uses a process-wide counter to disambiguate repeated operator names, so the test can fail when another test creates a Sink V2 operator first.
   
   ### Summary and Changelog
   
   Update the Sink V2 UID assertion to accept the optional numeric disambiguation suffix while continuing to verify the stable operator name and table identity components.
   
   ### Impact
   
   Test-only change. There is no public API, runtime behavior, or performance impact.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19623:
URL: https://github.com/apache/hudi/pull/19623#issuecomment-5281236865

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b1a30562ab4cb834a7ab679ad6544a0a2b28318f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16276",
       "triggerID" : "b1a30562ab4cb834a7ab679ad6544a0a2b28318f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b1a30562ab4cb834a7ab679ad6544a0a2b28318f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16276) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #19623:
URL: https://github.com/apache/hudi/pull/19623#issuecomment-5284673064

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19623:
URL: https://github.com/apache/hudi/pull/19623#discussion_r3775229171


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/v2/utils/TestPipelinesV2.java:
##########
@@ -78,7 +79,8 @@ void testSinkUsesModeSpecificParallelismAndStableIdentity() {
 
     assertEquals(4, sink.getTransformation().getParallelism());
     assertEquals("sink_v2", sink.getTransformation().getName());

Review Comment:
   πŸ€– nit: the regex is a bit opaque inline β€” could you extract it to a named constant or add a brief comment explaining what the optional `_\d+` suffix represents (e.g. a random/instance suffix added at runtime)?
   
   <sub><i>⚠️ AI-generated; verify before applying. React πŸ‘/πŸ‘Ž to flag quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19623:
URL: https://github.com/apache/hudi/pull/19623#issuecomment-5280217722

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b1a30562ab4cb834a7ab679ad6544a0a2b28318f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16276",
       "triggerID" : "b1a30562ab4cb834a7ab679ad6544a0a2b28318f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b1a30562ab4cb834a7ab679ad6544a0a2b28318f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16276) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #19623:
URL: https://github.com/apache/hudi/pull/19623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19623:
URL: https://github.com/apache/hudi/pull/19623#issuecomment-5280159141

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b1a30562ab4cb834a7ab679ad6544a0a2b28318f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b1a30562ab4cb834a7ab679ad6544a0a2b28318f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b1a30562ab4cb834a7ab679ad6544a0a2b28318f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(flink): stabilize Sink V2 UID assertion [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19623:
URL: https://github.com/apache/hudi/pull/19623#issuecomment-5280518502

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19623?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 77.00%. Comparing base ([`b2174b6`](https://app.codecov.io/gh/apache/hudi/commit/b2174b6f9ea30235cabf39d8269f179e9f670a87?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b1a3056`](https://app.codecov.io/gh/apache/hudi/commit/b1a30562ab4cb834a7ab679ad6544a0a2b28318f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19623      +/-   ##
   ============================================
   - Coverage     77.50%   77.00%   -0.50%     
   + Complexity    32862    32812      -50     
   ============================================
     Files          2524     2524              
     Lines        139355   139988     +633     
     Branches      16747    16918     +171     
   ============================================
   - Hits         108002   107804     -198     
   - Misses        23781    24567     +786     
   - Partials       7572     7617      +45     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [hudi-common](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.17% <ΓΈ> (-0.10%)` | :arrow_down: |
   | [hudi-client](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.42% <ΓΈ> (-0.31%)` | :arrow_down: |
   | [hudi-flink](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.85% <ΓΈ> (-1.90%)` | :arrow_down: |
   | [hudi-spark-datasource](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.72% <ΓΈ> (-0.85%)` | :arrow_down: |
   | [hudi-utilities](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.64% <ΓΈ> (ΓΈ)` | |
   | [hudi-cli](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.32% <ΓΈ> (+0.06%)` | :arrow_up: |
   | [hudi-hadoop](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.80% <ΓΈ> (-0.15%)` | :arrow_down: |
   | [hudi-sync](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.58% <ΓΈ> (ΓΈ)` | |
   | [hudi-io](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.47% <ΓΈ> (ΓΈ)` | |
   | [hudi-timeline-service](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.44% <ΓΈ> (ΓΈ)` | |
   | [hudi-cloud](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.06% <ΓΈ> (ΓΈ)` | |
   | [hudi-kafka-connect](https://app.codecov.io/gh/apache/hudi/pull/19623/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.20% <ΓΈ> (ΓΈ)` | |
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/19623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [flink-integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.88% <ΓΈ> (-12.31%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.86% <ΓΈ> (+<0.01%)` | :arrow_up: |
   | [integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `13.63% <ΓΈ> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.51% <ΓΈ> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 72 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19623/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org