You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pluradj <gi...@git.apache.org> on 2016/06/03 17:08:44 UTC
[GitHub] incubator-tinkerpop pull request #329: use mockito-core instead of mockito-a...
GitHub user pluradj opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/329
use mockito-core instead of mockito-all to avoid hamcrest conflict
https://issues.apache.org/jira/browse/TINKERPOP-1318
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pluradj/incubator-tinkerpop TINKERPOP-1318
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit 27eedc478b58cd9dee571960091a3c6505f2379e
Author: Jason Plurad <pl...@us.ibm.com>
Date: 2016-06-03T17:05:10Z
use mockito-core instead of mockito-all to avoid hamcrest conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #329: TINKERPOP-1318: use mockito-core inst...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #329: TINKERPOP-1318: use mockito-core instead of ...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/329
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #329: TINKERPOP-1318: use mockito-core instead of ...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/329
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #329: TINKERPOP-1318: use mockito-core instead of ...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/329
This change is simple enough and shouldn't impact anything (short of an incompatibility between mockito and the version of hamcrest here, but the tests pass so it should be ok.)
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #329: TINKERPOP-1318: use mockito-core instead of ...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/329
Yes, I ran integration tests with `-DincludeNeo4j`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #329: use mockito-core instead of mockito-all to a...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/329
Do integration tests pass? ... that will be all I care about. @spmallette will have deeper thoughts on the matter as he uses Mockito.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---