[GitHub] [ozone] smengcl commented on a diff in pull request #5175: HDDS-9159. [Snapshot] Implement snapshot disk usage: Referenced size

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on code in PR #5175:
URL: https://github.com/apache/ozone/pull/5175#discussion_r1295130027


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotInfo.java:
##########
@@ -589,14 +610,17 @@ public boolean equals(Object o) {
         Objects.equals(
             globalPreviousSnapshotId, that.globalPreviousSnapshotId) &&
         snapshotPath.equals(that.snapshotPath) &&
-        checkpointDir.equals(that.checkpointDir);
+        checkpointDir.equals(that.checkpointDir) &&
+        Objects.equals(deepClean, that.deepClean) &&

Review Comment:
   Yup let me add that as well for the sake of completeness.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org