You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/14 21:55:19 UTC
Review Request: Changed master/slave::Flags to inherit from logging::Flags
instead of compose.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9931/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/flags/flags.hpp f701ae99ef5cf2fa8ba05e94fd5b569cc690b000
src/local/local.cpp af4b5e1af7be94114c09464eba93b18276678ef5
src/master/flags.hpp b5729a8eaa7aa9a358e2d2e46aea4fd46b220662
src/master/main.cpp ca0abeca09ce1263984e873d068d83e277e36b04
src/master/master.hpp c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7
src/master/master.cpp 16972e853e7dc74a2658759f66b4a5a458467542
src/slave/flags.hpp 22b8bd6b0cced19093153a9e967ff272615de748
src/slave/main.cpp a7567f7f923f289e8e3da53022a46031bb3bcd1d
src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200
src/slave/slave.cpp 53eccb91b158f936763ab5d03d3a6f50fef1d596
src/tests/allocator_tests.cpp b953cd1b4a772a5de956d1354eafa6dd23bdd4ca
src/tests/gc_tests.cpp fbdd6d650751dd1ef241c86bcee8a383d73d9a4b
src/tests/master_tests.cpp 6d424d80dac6576c98372118b958c68503500cbf
src/tests/status_update_manager_tests.cpp 2c1e0629b11d69a1c08b25cfca6f6342605b676f
src/tests/utils.hpp 7b8bd9f145cdf86910abdcd7bffe9cfd2c61c8cd
Diff: https://reviews.apache.org/r/9931/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Changed master/slave::Flags to inherit from
logging::Flags instead of compose.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 14, 2013, 9:54 p.m., Vinod Kone wrote:
> > src/flags/flags.hpp, lines 98-107
> > <https://reviews.apache.org/r/9931/diff/1/?file=270775#file270775line98>
> >
> > Aren't we placing the first argument on a new line too, except for constructors?
In these cases, it's not clear to me that putting the first argument on a newline would reduce jaggedness any more.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9931/#review17921
-----------------------------------------------------------
On March 14, 2013, 8:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9931/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:55 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/flags/flags.hpp f701ae99ef5cf2fa8ba05e94fd5b569cc690b000
> src/local/local.cpp af4b5e1af7be94114c09464eba93b18276678ef5
> src/master/flags.hpp b5729a8eaa7aa9a358e2d2e46aea4fd46b220662
> src/master/main.cpp ca0abeca09ce1263984e873d068d83e277e36b04
> src/master/master.hpp c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7
> src/master/master.cpp 16972e853e7dc74a2658759f66b4a5a458467542
> src/slave/flags.hpp 22b8bd6b0cced19093153a9e967ff272615de748
> src/slave/main.cpp a7567f7f923f289e8e3da53022a46031bb3bcd1d
> src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200
> src/slave/slave.cpp 53eccb91b158f936763ab5d03d3a6f50fef1d596
> src/tests/allocator_tests.cpp b953cd1b4a772a5de956d1354eafa6dd23bdd4ca
> src/tests/gc_tests.cpp fbdd6d650751dd1ef241c86bcee8a383d73d9a4b
> src/tests/master_tests.cpp 6d424d80dac6576c98372118b958c68503500cbf
> src/tests/status_update_manager_tests.cpp 2c1e0629b11d69a1c08b25cfca6f6342605b676f
> src/tests/utils.hpp 7b8bd9f145cdf86910abdcd7bffe9cfd2c61c8cd
>
> Diff: https://reviews.apache.org/r/9931/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Changed master/slave::Flags to inherit from
logging::Flags instead of compose.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9931/#review17921
-----------------------------------------------------------
Ship it!
src/flags/flags.hpp
<https://reviews.apache.org/r/9931/#comment37925>
Aren't we placing the first argument on a new line too, except for constructors?
- Vinod Kone
On March 14, 2013, 8:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9931/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:55 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/flags/flags.hpp f701ae99ef5cf2fa8ba05e94fd5b569cc690b000
> src/local/local.cpp af4b5e1af7be94114c09464eba93b18276678ef5
> src/master/flags.hpp b5729a8eaa7aa9a358e2d2e46aea4fd46b220662
> src/master/main.cpp ca0abeca09ce1263984e873d068d83e277e36b04
> src/master/master.hpp c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7
> src/master/master.cpp 16972e853e7dc74a2658759f66b4a5a458467542
> src/slave/flags.hpp 22b8bd6b0cced19093153a9e967ff272615de748
> src/slave/main.cpp a7567f7f923f289e8e3da53022a46031bb3bcd1d
> src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200
> src/slave/slave.cpp 53eccb91b158f936763ab5d03d3a6f50fef1d596
> src/tests/allocator_tests.cpp b953cd1b4a772a5de956d1354eafa6dd23bdd4ca
> src/tests/gc_tests.cpp fbdd6d650751dd1ef241c86bcee8a383d73d9a4b
> src/tests/master_tests.cpp 6d424d80dac6576c98372118b958c68503500cbf
> src/tests/status_update_manager_tests.cpp 2c1e0629b11d69a1c08b25cfca6f6342605b676f
> src/tests/utils.hpp 7b8bd9f145cdf86910abdcd7bffe9cfd2c61c8cd
>
> Diff: https://reviews.apache.org/r/9931/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>