You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/07/31 20:59:38 UTC
Review help: sparse-dirs deselection (issue #2843)
Our Summer of Code student Guo Rui ('firemeteor') has been making
terrific progress on issue #2843, which is about providing a deselection
(i.e., "folding up") interface for sparse-directories.
I'm his official mentor, but I've gotten behind on reviewing his
changes. I was at OSCON all last week, and intended to catch up this
week, but have fallen ill and will not be able to (despite what some
might say, one cannot review code and sleep at the same time).
If anyone can help out by reviewing r32190, r32264, and r32265, that
would be great. I'm sorry to offload my mentoring responsibilities like
this; blame the microbes!
The general state of the branch is that he's mostly done. Today I got
this private email from him (I don't think he'll mind my quoting it
here):
> I'm going to present my paper next week [...]. So the project will
> be put off for a moment. However, I think the current state of the
> project is basically satisfactory. There are only a few known
> issues marked with TODO. More tests and feedbacks are needed to
> further improve the quality of the code.
>
> PS: Some modifications related to "Copy" are blocked by the pending
> patch and thus are kept local. But I don't think this will be any
> problem.
So I think what remains is finishing up, not reworking basic questions
about the feature or anything like that.
While I'm cataloguing my recent failures as a mentor, I should also
mention the following posts from him:
A trunk patch awaiting review (blocks some of his branch work):
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=141254
From: "Rui, Guo" <ti...@mail.ustc.edu.cn>
To: dev@subversion.tigris.org
Subject: Re: [PATCH] svn_wc_relocate3() on deleted target.
Date: Tue, 22 Jul 2008 11:58:24 +0800
Message-ID: <20...@Behemoth.ustc.edu.cn>
He asks an as-yet-unanswered question (related to r32264) here:
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=141259
From: "Rui, Guo" <ti...@mail.ustc.edu.cn>
To: subversion development <de...@subversion.tigris.org>
Subject: Re: svn commit: r31987 - in branches/issue-2843-dev/subversion:
libsvn_wc tests/cmdline
Date: Tue, 22 Jul 2008 20:03:49 +0800
Message-ID: <20...@Behemoth.ustc.edu.cn>
And another unanswered question (about mergeinfo) here:
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=141315
From: "Rui, Guo" <ti...@mail.ustc.edu.cn>
To: dev@subversion.tigris.org
Cc: Karl Fogel <kf...@red-bean.com>
Subject: Re: svn commit: r31986 - in branches/issue-2843-dev/subversion:
libsvn_client libsvn_wc
Date: Thu, 24 Jul 2008 22:44:02 +0800
Message-ID: <20...@Behemoth.ustc.edu.cn>
I'm going back to sleep now :-). I'll appreciate any help anyone can
give Guo Rui, and I'll try to do as much of the above as I can too, of
course. But I think I'm probably out of commission through the weekend,
given the way I feel <blatant-appeal-for-sympathy shameless="true"/>.
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Review help: sparse-dirs deselection (issue #2843)
Posted by Stefan Sperling <st...@elego.de>.
On Thu, Jul 31, 2008 at 04:59:38PM -0400, Karl Fogel wrote:
> While I'm cataloguing my recent failures as a mentor, I should also
> mention the following posts from him:
I've taken a look at each of them. I have nothing much informative
to add but thought I'd post anyway.
> A trunk patch awaiting review (blocks some of his branch work):
>
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=141254
> From: "Rui, Guo" <ti...@mail.ustc.edu.cn>
> To: dev@subversion.tigris.org
> Subject: Re: [PATCH] svn_wc_relocate3() on deleted target.
> Date: Tue, 22 Jul 2008 11:58:24 +0800
> Message-ID: <20...@Behemoth.ustc.edu.cn>
Reading the message, it looks like the patch is still incomplete.
You have discussed replaced and absent entries, but the patch as is
just handles deleted ones. Is there an updated patch somewhere?
Also, I cannot reproduce the problem by running the commands
given. For me, the switch command prints nothing and exists with
status 0, for both 1.5 and trunk. A "real" runnable shell script
that reproduces the problem would be nice.
> He asks an as-yet-unanswered question (related to r32264) here:
>
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=141259
> From: "Rui, Guo" <ti...@mail.ustc.edu.cn>
> To: subversion development <de...@subversion.tigris.org>
> Subject: Re: svn commit: r31987 - in branches/issue-2843-dev/subversion:
> libsvn_wc tests/cmdline
> Date: Tue, 22 Jul 2008 20:03:49 +0800
> Message-ID: <20...@Behemoth.ustc.edu.cn>
That is way over my head. No idea, sorry.
> And another unanswered question (about mergeinfo) here:
>
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=141315
> From: "Rui, Guo" <ti...@mail.ustc.edu.cn>
> To: dev@subversion.tigris.org
> Cc: Karl Fogel <kf...@red-bean.com>
> Subject: Re: svn commit: r31986 - in branches/issue-2843-dev/subversion:
> libsvn_client libsvn_wc
> Date: Thu, 24 Jul 2008 22:44:02 +0800
> Message-ID: <20...@Behemoth.ustc.edu.cn>
This message reminds me that Julian said that we should check how
sparse checkouts interact with tree conflicts.
I agree that, for now, the merge can behave as if the missing item
was deleted, which is currently standard practice for such cases
(also known as "punting" ;)
But in the future, we might want to raise a tree conflict there.
Trying to merge something into an absent subtree is a tree conflict.
But you don't need to concern yourselves with that right now.
We'll take care of it later on the tree-conflicts branch, when we get
to the point of dealing with sparse checkouts.
As for the mergeinfo question:
I'm not entirely sure either how to handle mergeinfo for directories
that are missing because of sparse checkouts, but I guess as far as
the mergeinfo is concerned, it makes no difference whether the missing
path is a file or whether it is a directory -- a path is a path, right?
In other words, I guess that doing whatever is currently done for absent
files is fine for absent directories, too.
Then again, I'm not a mergeinfo expert, so please get advice from
someone more competent in that area as well.
> I'm going back to sleep now :-). I'll appreciate any help anyone can
> give Guo Rui, and I'll try to do as much of the above as I can too, of
> course. But I think I'm probably out of commission through the weekend,
> given the way I feel <blatant-appeal-for-sympathy shameless="true"/>.
Oh dear :(
Get well soon!
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org