[commons-fileupload] branch master updated: Minor Improvement:

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git


The following commit(s) were added to refs/heads/master by this push:
     new 386323c  Minor Improvement:
     new 3d9884c  Merge pull request #51 from arturobernalg/feature/minor_improvement1
386323c is described below

commit 386323c05f8321f37716f3e0667f24ff91621f47
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Wed Dec 30 09:07:26 2020 +0100

    Minor Improvement:
    
    * Add final
    * Remove Unused import
    * Remove Unnecessary interface modifier
---
 src/main/java/org/apache/commons/fileupload2/FileItemStream.java     | 2 +-
 .../org/apache/commons/fileupload2/impl/FileItemIteratorImpl.java    | 4 ++--
 .../java/org/apache/commons/fileupload2/DefaultFileItemTest.java     | 5 -----
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/commons/fileupload2/FileItemStream.java b/src/main/java/org/apache/commons/fileupload2/FileItemStream.java
index e36a2fe..4b31185 100644
--- a/src/main/java/org/apache/commons/fileupload2/FileItemStream.java
+++ b/src/main/java/org/apache/commons/fileupload2/FileItemStream.java
@@ -40,7 +40,7 @@ public interface FileItemStream extends FileItemHeadersSupport {
      * {@link java.util.Iterator#hasNext()} has been invoked on the
      * iterator, which created the {@link FileItemStream}.
      */
-    public static class ItemSkippedException extends IOException {
+    class ItemSkippedException extends IOException {
 
         /**
          * The exceptions serial version UID, which is being used
diff --git a/src/main/java/org/apache/commons/fileupload2/impl/FileItemIteratorImpl.java b/src/main/java/org/apache/commons/fileupload2/impl/FileItemIteratorImpl.java
index 482a196..be258bb 100644
--- a/src/main/java/org/apache/commons/fileupload2/impl/FileItemIteratorImpl.java
+++ b/src/main/java/org/apache/commons/fileupload2/impl/FileItemIteratorImpl.java
@@ -149,7 +149,7 @@ public class FileItemIteratorImpl implements FileItemIterator {
                                  : contentLengthInt;
                                  // CHECKSTYLE:ON
 
-        InputStream input; // N.B. this is eventually closed in MultipartStream processing
+        final InputStream input; // N.B. this is eventually closed in MultipartStream processing
         if (sizeMax >= 0) {
             if (requestSize != -1 && requestSize > sizeMax) {
                 throw new SizeLimitExceededException(
@@ -218,7 +218,7 @@ public class FileItemIteratorImpl implements FileItemIterator {
         }
         final MultipartStream multi = getMultiPartStream();
         for (;;) {
-            boolean nextPart;
+            final boolean nextPart;
             if (skipPreamble) {
                 nextPart = multi.skipPreamble();
             } else {
diff --git a/src/test/java/org/apache/commons/fileupload2/DefaultFileItemTest.java b/src/test/java/org/apache/commons/fileupload2/DefaultFileItemTest.java
index e1d5101..5a458e4 100644
--- a/src/test/java/org/apache/commons/fileupload2/DefaultFileItemTest.java
+++ b/src/test/java/org/apache/commons/fileupload2/DefaultFileItemTest.java
@@ -29,11 +29,6 @@ import java.io.OutputStream;
 import java.util.Arrays;
 import org.apache.commons.io.FileUtils;
 
-import org.apache.commons.fileupload2.DefaultFileItem;
-import org.apache.commons.fileupload2.DefaultFileItemFactory;
-import org.apache.commons.fileupload2.FileItem;
-import org.apache.commons.fileupload2.FileItemFactory;
-import org.apache.commons.io.FileUtils;
 
 import org.junit.jupiter.api.Test;