You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/05 21:29:01 UTC
[GitHub] [couchdb-erlfdb] kocolosk opened a new pull request #35: Automate execution of binding tests
kocolosk opened a new pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35
This PR adds a GHA job that uses the same container image as the .devcontainer. It runs 10000 operations for each of the binding tests for every supported API version (currently 610 and 620). It relies on a service container for the underlying FDB server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750666862
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
<img width="1038" alt="Screen Shot 2021-11-16 at 4 11 18 PM" src="https://user-images.githubusercontent.com/211822/142066408-dc578993-b689-4b37-bae5-fc8bced07f3d.png">
Hmm I saw you handle in the https://hub.docker.com/orgs/apache/teams/couchdbpmc list. That's where I got the idea.
If not you can request access with a ticket similar to: https://issues.apache.org/jira/browse/INFRA-22082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750692162
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
It seems we've moved away from `couchdbdev` to new image repositories under apache in apache/couchdb-ci@4cff8560fd7. We now have separate repos for Debian / Ubuntu / CentOS, e.g. https://hub.docker.com/r/apache/couchdbci-debian
@wohali do you have any guidance for how we should publish the CI image used by erlfdb here? The Dockerfile is already maintained as part of this repo (it's the same one used for the devcontainer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750808036
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
It feels like overkill to create a whole new repository under apache. On the other hand, it also seems weird to have a tag like
apache/couchdbci-debian:erlfdb-erlang-24.1.4-fdb-6.3.18
that's built from a completely different `Dockerfile` than the other tags. I think that's where I'm leaning, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750673134
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
Browsing around some more in Docker Hub and Apache, I don't know if Apache Infra even manages couchdbdev? Does some other organization manage it, IBM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750664079
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
I don't think I do?
```
docker push couchdbdev/erlfdb-bindingtester-ci:24.1.4-6.3.18
The push refers to repository [docker.io/couchdbdev/erlfdb-bindingtester-ci]
6af377e9d3b0: Preparing
171d20eabb03: Preparing
ebab07de38b6: Preparing
74ced2ed5ac3: Preparing
317d0710ff61: Preparing
1879793a4833: Waiting
65e2e15d809b: Waiting
2ec9a1e902dc: Waiting
28c183738f67: Waiting
9e28eabfde8b: Waiting
52ed97b6b9c6: Waiting
2ff7f567e600: Waiting
42aff4deb538: Waiting
d6a325d281f2: Waiting
denied: requested access to the resource is denied
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750647468
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [610, 620, 630]
Review comment:
Do we know it works with 610. I'd be ok restricting it to 620 as the lowest version if we don't actively test 6.1.x clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750647468
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [610, 620, 630]
Review comment:
~Do we know it works with 610. I'd be ok restricting it to 620 as the lowest version if we don't actively test 6.1.x clients.~
Aha I see that we do test 610 as well. Let's keep it then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750655950
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [610, 620, 630]
Review comment:
We can't *build* against a 6.1.x client because we don't guard all the calls to new endpoints with `#ifdef` macros, but if someone wants to use a 6.2.x client and downgrade to API version 610 because that's what they're application is expecting, that works (or at least it passes the binding tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #35: Automate execution of binding tests
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r745584594
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
This image should probably be published under `couchdbdev` instead of my personal account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750651697
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
Good point. Would it be possible to push this do couchdbdev? I think you have Docker Hub permissions to push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750663201
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [610, 620, 630]
Review comment:
Yup, that makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750841594
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [620, 630]
+ include:
+ # The `scripted` test only supports the latest API version
+ - test-name: scripted
+ api-version: 630
+ container:
+ image: kocolosk/erlfdb-bindingtester-ci:24-6.3.18
Review comment:
Resolved in 1b24a3d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#discussion_r750650768
##########
File path: .github/workflows/ci.yml
##########
@@ -90,3 +90,47 @@ jobs:
if: ${{ failure() }}
with:
limit-access-to-actor: true
+
+ binding_tester:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ test-name: [api, directory, directory_hca, tuple]
+ api-version: [610, 620, 630]
Review comment:
Aha I see that we do test 610 as well. Let's keep it then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35#issuecomment-971692434
Squashing a couple of commits and will merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk merged pull request #35: Automate execution of binding tests, support API 630
Posted by GitBox <gi...@apache.org>.
kocolosk merged pull request #35:
URL: https://github.com/apache/couchdb-erlfdb/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org