You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/21 11:44:32 UTC
[GitHub] [maven] mthmulders opened a new pull request #363: [MNG-5760] --resume feature (part 2)
mthmulders opened a new pull request #363:
URL: https://github.com/apache/maven/pull/363
This pull request is a follow-up on #342, in which two little bugs had sneaked in. Since the feature hasn't been released yet, I haven't added new JIRA tickets for these bugs.
1. Resolution of **resume.properties** file didn't work as expected. I have fixed it and added a unit test to illustrate how it should work.
1. When the `excludedProjects` property in the **resume.properties** file was empty, the build would break (since it added an empty project to the list of excluded projects). Of course, this shouldn't happen, so that's fixed too.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [X] You have run the [Core IT][core-its] successfully. Also, the previously added test case for this feature is now added to the suite.
**ICLA has been signed by @MartinKanters and myself. CCLA has been signed by our employer, Info Support.**
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #363: [MNG-5760] --resume feature (part 2)
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #363:
URL: https://github.com/apache/maven/pull/363#issuecomment-658932830
Merged in [117cfde44e34a45f2b38929aa164e61650681aeb](https://github.com/apache/maven/commit/117cfde44e34a45f2b38929aa164e61650681aeb)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on a change in pull request #363: [MNG-5760] --resume feature (part 2)
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #363:
URL: https://github.com/apache/maven/pull/363#discussion_r443247628
##########
File path: maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionDataRepository.java
##########
@@ -105,7 +109,7 @@ public void removeResumptionData( MavenProject rootProject )
private Properties loadResumptionFile( Path rootBuildDirectory )
{
Properties properties = new Properties();
- Path path = Paths.get( RESUME_PROPERTIES_FILENAME ).resolve( rootBuildDirectory );
+ Path path = rootBuildDirectory.resolve( Paths.get( RESUME_PROPERTIES_FILENAME ) );
Review comment:
You can use `Path.resolve(String)` instead of first explicitly converting the argument to Path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #363: [MNG-5760] --resume feature (part 2)
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #363:
URL: https://github.com/apache/maven/pull/363#discussion_r443248576
##########
File path: maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionDataRepository.java
##########
@@ -105,7 +109,7 @@ public void removeResumptionData( MavenProject rootProject )
private Properties loadResumptionFile( Path rootBuildDirectory )
{
Properties properties = new Properties();
- Path path = Paths.get( RESUME_PROPERTIES_FILENAME ).resolve( rootBuildDirectory );
+ Path path = rootBuildDirectory.resolve( Paths.get( RESUME_PROPERTIES_FILENAME ) );
Review comment:
Thanks, didn't know that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] MartinKanters closed pull request #363: [MNG-5760] --resume feature (part 2)
Posted by GitBox <gi...@apache.org>.
MartinKanters closed pull request #363:
URL: https://github.com/apache/maven/pull/363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org