You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/15 20:47:44 UTC

[GitHub] [flink] syhily opened a new pull request, #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

syhily opened a new pull request, #19976:
URL: https://github.com/apache/flink/pull/19976

   ## What is the purpose of the change
   
   The current Pulsar connector would subscribe the Pulsar internal system topics, which is not allowed.
   
   ## Brief change log
   
   Add a method for filtering the system topics in Pulsar.
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] imaffe commented on a diff in pull request #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

Posted by GitBox <gi...@apache.org>.
imaffe commented on code in PR #19976:
URL: https://github.com/apache/flink/pull/19976#discussion_r898633161


##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicNameUtils.java:
##########
@@ -30,13 +31,35 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.regex.Pattern;
 
 import static org.apache.flink.util.Preconditions.checkArgument;
+import static org.apache.pulsar.common.naming.NamespaceName.SYSTEM_NAMESPACE;
+import static org.apache.pulsar.common.naming.TopicDomain.persistent;
 
 /** util for topic name. */
 @Internal
 public final class TopicNameUtils {
 
+    private static final Pattern HEARTBEAT_NAMESPACE_PATTERN =

Review Comment:
   This change is cool, we can use this filter system topics in PulsarCatalog as well ~ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily closed pull request #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

Posted by GitBox <gi...@apache.org>.
syhily closed pull request #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex
URL: https://github.com/apache/flink/pull/19976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19976:
URL: https://github.com/apache/flink/pull/19976#issuecomment-1156917077

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "67a21b87b36684c7dd551e29e77663be2487075e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "67a21b87b36684c7dd551e29e77663be2487075e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 67a21b87b36684c7dd551e29e77663be2487075e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org