You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2018/05/25 12:14:19 UTC

flink git commit: [hotfix] Don't swallow exception in CliFrontend#handleArgException

Repository: flink
Updated Branches:
  refs/heads/release-1.5 6cd84a8db -> e185691f4


[hotfix] Don't swallow exception in CliFrontend#handleArgException


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/e185691f
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/e185691f
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/e185691f

Branch: refs/heads/release-1.5
Commit: e185691f4e9720cc703b52ec32244362c83b39bc
Parents: 6cd84a8
Author: Till Rohrmann <tr...@apache.org>
Authored: Fri May 25 14:13:41 2018 +0200
Committer: Till Rohrmann <tr...@apache.org>
Committed: Fri May 25 14:13:41 2018 +0200

----------------------------------------------------------------------
 .../src/main/java/org/apache/flink/client/cli/CliFrontend.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/e185691f/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
----------------------------------------------------------------------
diff --git a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java b/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
index 95a9949..fd12a73 100644
--- a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
+++ b/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
@@ -850,7 +850,7 @@ public class CliFrontend {
 	 * @return The return code for the process.
 	 */
 	private static int handleArgException(CliArgsException e) {
-		LOG.error("Invalid command line arguments. " + (e.getMessage() == null ? "" : e.getMessage()));
+		LOG.error("Invalid command line arguments.", e);
 
 		System.out.println(e.getMessage());
 		System.out.println();
@@ -865,6 +865,7 @@ public class CliFrontend {
 	 * @return The return code for the process.
 	 */
 	private static int handleParametrizationException(ProgramParametrizationException e) {
+		LOG.error("Program has not been parametrized properly.", e);
 		System.err.println(e.getMessage());
 		return 1;
 	}