You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/03/18 01:51:58 UTC
Review Request 45009: Transition `filesystem_tests.cpp` to use
`path::join`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45009/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Transition `filesystem_tests.cpp` to use `path::join`.
This commit will fix a test that fails due to inconsistent usage of path
delimiting characters.
Historically in Mesos, it has been common to join paths by adding
strings. For example: `somePath + "/yourFile"`. The '/' character in
particular is contentious, and can cause problems if you're not
consistent in your usage. For example, if `somePath` already uses '\' as
a path separator, then joining the string `"/yourFile"` introduces
inconsistency in the path delimiter usage, resulting in undesirable
behavior.
Review: https://reviews.apache.org/r/45009
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/45009/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 45009: Transition `filesystem_tests.cpp` to use
`path::join`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45009/#review124655
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On March 18, 2016, 12:51 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45009/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 12:51 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Transition `filesystem_tests.cpp` to use `path::join`.
>
> This commit will fix a test that fails due to inconsistent usage of path
> delimiting characters.
>
> Historically in Mesos, it has been common to join paths by adding
> strings. For example: `somePath + "/yourFile"`. The '/' character in
> particular is contentious, and can cause problems if you're not
> consistent in your usage. For example, if `somePath` already uses '\' as
> a path separator, then joining the string `"/yourFile"` introduces
> inconsistency in the path delimiter usage, resulting in undesirable
> behavior.
>
> Review: https://reviews.apache.org/r/45009
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
>
> Diff: https://reviews.apache.org/r/45009/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 45009: Transition `filesystem_tests.cpp` to use
`path::join`.
Posted by Yi Sun <yi...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45009/#review125448
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Sun
On March 18, 2016, 12:51 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45009/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 12:51 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Transition `filesystem_tests.cpp` to use `path::join`.
>
> This commit will fix a test that fails due to inconsistent usage of path
> delimiting characters.
>
> Historically in Mesos, it has been common to join paths by adding
> strings. For example: `somePath + "/yourFile"`. The '/' character in
> particular is contentious, and can cause problems if you're not
> consistent in your usage. For example, if `somePath` already uses '\' as
> a path separator, then joining the string `"/yourFile"` introduces
> inconsistency in the path delimiter usage, resulting in undesirable
> behavior.
>
> Review: https://reviews.apache.org/r/45009
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
>
> Diff: https://reviews.apache.org/r/45009/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>