[GitHub] nifi pull request #1034: [NIFI-2810] Allow Content Type to be set in PutS3Ob...

[pvillard31 <gi...@git.apache.org>]

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1034#discussion_r80250174
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java ---
    @@ -132,6 +132,19 @@
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
             .build();
     
    +    public static final PropertyDescriptor CONTENT_TYPE = new PropertyDescriptor.Builder()
    +        .name("Content Type")
    +        .description("Sets the Content-Type HTTP header indicating the type of content stored in the associated " +
    +                "object. The value of this header is a standard MIME type.\n" +
    +                "AWS S3 Java client will attempt to determine the correct content type if one hasn't been set" +
    +                " yet. Users are responsible for ensuring a suitable content type is set when uploading streams. If " +
    +                "no content type is provided and cannot be determined by the filename, the default content type " +
    +                "\"application/octet-stream\" will be used.")
    --- End diff --
    
    Could you set "application/octet-stream" as default value of the property? It's more user-friendly because user will know what is the default value which is used without looking at the description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---