You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by mp...@apache.org on 2015/06/13 18:00:32 UTC
[3/3] ambari git commit: AMBARI-11841. Alerts received in single
heartbeat should be processed in batch. Javadoc fix. (mpapirkovskyy)
AMBARI-11841. Alerts received in single heartbeat should be processed in batch. Javadoc fix. (mpapirkovskyy)
Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/bb486eb8
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/bb486eb8
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/bb486eb8
Branch: refs/heads/branch-2.1
Commit: bb486eb8d1f52b53b4bd382d5aca9bbf0554e145
Parents: a886385
Author: Myroslav Papirkovskyy <mp...@hortonworks.com>
Authored: Sat Jun 13 18:57:52 2015 +0300
Committer: Myroslav Papirkovskyy <mp...@hortonworks.com>
Committed: Sat Jun 13 18:58:42 2015 +0300
----------------------------------------------------------------------
.../apache/ambari/server/agent/HeartBeatHandler.java | 5 +++++
.../listeners/alerts/AlertReceivedListener.java | 14 ++++++++++----
2 files changed, 15 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ambari/blob/bb486eb8/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
index 029341c..1c993ef 100644
--- a/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
+++ b/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
@@ -310,6 +310,11 @@ public class HeartBeatHandler {
if (null != heartbeat.getAlerts()) {
AlertEvent event = new AlertReceivedEvent(heartbeat.getAlerts());
+ for (Alert alert : event.getAlerts()) {
+ if (alert.getHostName() == null) {
+ alert.setHostName(hostname);
+ }
+ }
alertEventPublisher.publish(event);
}
http://git-wip-us.apache.org/repos/asf/ambari/blob/bb486eb8/ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java b/ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
index 53b0cb5..0dd14cb 100644
--- a/ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
+++ b/ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
@@ -250,6 +250,12 @@ public class AlertReceivedListener {
}
}
+ /**
+ * Saves alert and alert history entities in single transaction
+ * @param toCreate - new alerts, create alert and history
+ * @param toMerge - merge alert only
+ * @param toCreateHistoryAndMerge - create new history, merge alert
+ */
@Transactional
void saveEntities(Map<Alert, AlertCurrentEntity> toCreate, Map<Alert, AlertCurrentEntity> toMerge,
Map<Alert, AlertCurrentEntity> toCreateHistoryAndMerge) {
@@ -269,10 +275,10 @@ public class AlertReceivedListener {
if (LOG.isDebugEnabled()) {
LOG.debug(
- "Alert State Merged: CurrentId {}, CurrentTimestamp {}, HistoryId {}, HistoryState {}",
- entity.getAlertId(), entity.getLatestTimestamp(),
- entity.getAlertHistory().getAlertId(),
- entity.getAlertHistory().getAlertState());
+ "Alert State Merged: CurrentId {}, CurrentTimestamp {}, HistoryId {}, HistoryState {}",
+ entity.getAlertId(), entity.getLatestTimestamp(),
+ entity.getAlertHistory().getAlertId(),
+ entity.getAlertHistory().getAlertState());
}
}
}