[GitHub] [flink] bowenli86 commented on a change in pull request #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog
URL: https://github.com/apache/flink/pull/8222#discussion_r277801129
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPartition.java
 ##########
 @@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog;
+
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * Represents a partition object in catalog.
+ */
+public interface CatalogPartition {
+
+	/**
+	 * Get the PartitionSpec of the partition.
+	 *
+	 * @return the PartitionSpec of the partition.
+	 */
+	PartitionSpec getPartitionSpec();
+
+	/**
+	 * Get a map of properties associated with the partition.
+	 *
+	 * @return a map of properties with the partition
+	 */
+	Map<String, String> getProperties();
+
+	/**
+	 * Get a deep copy of the CatalogPartition instance.
+	 *
+	 * @return a copy of CatalogPartition instance
+	 */
+	CatalogPartition copy();
+
+	/**
+	 * Get a brief description of the database.
+	 *
+	 * @return an optional short description of the database
+	 */
+	Optional<String> getDescription();
+
+	/**
+	 * Get a detailed description of the database.
+	 *
+	 * @return an optional long description of the database
+	 */
+	Optional<String> getDetailedDescription();
+
+	/**
+	 * Represents a partition spec object.
+	 * Partition columns and values are NOT of strict order, and they need to be re-arranged to the correct order
+	 * by comparing with a list of strictly ordered partition keys.
+	 */
+	interface PartitionSpec {
 
 Review comment:
   Static vs. dynamic partition is more of a concept of how to insert/load data. Please see [here](https://cwiki.apache.org/confluence/display/Hive/DynamicPartitions)
   
   Their logical representation should be same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services