You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com> on 2013/04/17 19:46:07 UTC

Release target seems to be fixed

Give it a try.  It seems to be working now.

--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: Release target seems to be fixed

Posted by Alex Harui <ah...@adobe.com>.


On 4/17/13 9:17 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:

> Hi,
> 
>> It worked for me.  But I forgot to check whether a TLF_HOME environment
>> variable can point somewhere else.
> That was broken it ignored TLF_HOME if it was set.
Thanks for fixing that.  I made one adjustment to it just now.

> 
>> And I'm on Mac.
> Likewise so may be issue on PC?
I just saw it run on Windows.
> 
>> But I thought Justin said it was fixed?  Except maybe running directly from
>> the textlayout directory itself.
> 
> Think it need a bit more work to be 100% but it is working for me yes.
I won't be surprised if there are other issues, but now it works for me on
Mac and Win.

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui


Re: Release target seems to be fixed

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> It worked for me.  But I forgot to check whether a TLF_HOME environment
> variable can point somewhere else.  
That was broken it ignored TLF_HOME if it was set.

> And I'm on Mac.
Likewise so may be issue on PC?

> But I thought Justin said it was fixed?  Except maybe running directly from
> the textlayout directory itself.

Think it need a bit more work to be 100% but it is working for me yes.

Justin

Re: Release target seems to be fixed

Posted by Alex Harui <ah...@adobe.com>.
It worked for me.  But I forgot to check whether a TLF_HOME environment
variable can point somewhere else.  For me my tlf is in flex-tlf. And I'm on
Mac.

But I thought Justin said it was fixed?  Except maybe running directly from
the textlayout directory itself.


On 4/17/13 5:02 PM, "Gordon Smith" <go...@adobe.com> wrote:

> Alex, did this work on your system? It apparently doesn't on Justin's. I
> haven't tried it yet.
> 
> - Gordon
> 
> -----Original Message-----
> From: Justin Mclean [mailto:justin@classsoftware.com]
> Sent: Wednesday, April 17, 2013 4:36 PM
> To: dev@flex.apache.org
> Subject: Re: Release target seems to be fixed
> 
> Hi,
> 
>> What do you mean by a "common" named directory? Can't it look for a sibling
>> directory named flex-tlf?
> 
> It's looking for a sibling directory called "../flex-tlf/textLayout" or
> "../tlf/textLayput" from FLEX_HOME.
> 
> From build.xml:
> 
>     <available file="${FLEX_HOME}/../flex-tlf/textLayout"
>             type="dir"
>             property="TLF_HOME"
>             value="${FLEX_HOME}/../flex-tlf" />
> 
>     <available file="${FLEX_HOME}/../tlf/textLayout"
>             type="dir"
>             property="TLF_HOME"
>             value="${FLEX_HOME}/../tlf" />
> 
> Justin

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui


RE: Release target seems to be fixed

Posted by Gordon Smith <go...@adobe.com>.
Alex, did this work on your system? It apparently doesn't on Justin's. I haven't tried it yet.

- Gordon

-----Original Message-----
From: Justin Mclean [mailto:justin@classsoftware.com] 
Sent: Wednesday, April 17, 2013 4:36 PM
To: dev@flex.apache.org
Subject: Re: Release target seems to be fixed

Hi,

> What do you mean by a "common" named directory? Can't it look for a sibling directory named flex-tlf?

It's looking for a sibling directory called "../flex-tlf/textLayout" or "../tlf/textLayput" from FLEX_HOME.

>From build.xml:

    <available file="${FLEX_HOME}/../flex-tlf/textLayout" 
            type="dir" 
            property="TLF_HOME"
            value="${FLEX_HOME}/../flex-tlf" />

    <available file="${FLEX_HOME}/../tlf/textLayout" 
            type="dir" 
            property="TLF_HOME"
            value="${FLEX_HOME}/../tlf" />

Justin

Re: Release target seems to be fixed

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> What do you mean by a "common" named directory? Can't it look for a sibling directory named flex-tlf?

It's looking for a sibling directory called "../flex-tlf/textLayout" or "../tlf/textLayput" from FLEX_HOME.

From build.xml:

    <available file="${FLEX_HOME}/../flex-tlf/textLayout" 
            type="dir" 
            property="TLF_HOME"
            value="${FLEX_HOME}/../flex-tlf" />

    <available file="${FLEX_HOME}/../tlf/textLayout" 
            type="dir" 
            property="TLF_HOME"
            value="${FLEX_HOME}/../tlf" />

Justin

RE: Release target seems to be fixed

Posted by Gordon Smith <go...@adobe.com>.
What do you mean by a "common" named directory? Can't it look for a sibling directory named flex-tlf?

- Gordon

-----Original Message-----
From: Justin Mclean [mailto:justin@classsoftware.com] 
Sent: Wednesday, April 17, 2013 3:43 PM
To: dev@flex.apache.org
Subject: Re: Release target seems to be fixed

Hi,

> DidAlex's change require TLF_HOME to be set?
No but the build would break (in a ugly way) if it wasn't set and it couldn't find a "common" named directory.

I checked in a fix for that.

Justin

Re: Release target seems to be fixed

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> DidAlex's change require TLF_HOME to be set?
No but the build would break (in a ugly way) if it wasn't set and it couldn't find a "common" named directory.

I checked in a fix for that.

Justin

RE: Release target seems to be fixed

Posted by Gordon Smith <go...@adobe.com>.
DidAlex's change require TLF_HOME to be set? I thought we agreed it shouldn't be necessary.

- Gordon

-----Original Message-----
From: Justin Mclean [mailto:justin@classsoftware.com] 
Sent: Wednesday, April 17, 2013 3:22 PM
To: dev@flex.apache.org
Subject: Re: Release target seems to be fixed

Hi,

I'm modified build.xml to set TLF_HOME to env.TLF_HOME but not 100% sure if that the correct way to do it.

Justin

Re: Release target seems to be fixed

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

I'm modified build.xml to set TLF_HOME to env.TLF_HOME but not 100% sure if that the correct way to do it.

Justin

Re: Release target seems to be fixed

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> Give it a try.  It seems to be working now.
Broken for me - looks like value of TLF_HOME is not being picked up from the environment variable.

clean-external:
     [echo] cleaning ${TLF_HOME}

BUILD FAILED
/Users/justinmclean/Documents/ApacheFlexDevelopGit/build.xml:396: The following error occurred while executing this line:
/Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/build.xml:232: The following error occurred while executing this line:
/Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/projects/textLayout/build.xml:216: Basedir /Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/projects/textLayout/${TLF_HOME} does not exist

echo $TLF_HOME
/Users/justinmclean/Documents/ApacheFlexTLFGit/textLayout

Thanks,
Justin

Re: Release target seems to be fixed

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Well "ant release" now works for me - not tested the SDK it produces or run mustella tests or anything but it builds so that's a start.

Think the TLF_HOME checking still needs a little work.

In framework/projects/textLayput an "ant main"  will fail even if you have TLF_HOME environment variable set.

Thanks,
Justin