You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/18 15:05:33 UTC
[GitHub] [incubator-linkis-website] Beacontownfc opened a new pull request, #358: Add console compilation verification
Beacontownfc opened a new pull request, #358:
URL: https://github.com/apache/incubator-linkis-website/pull/358
This PR is able to fix this issue #264 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis-website] casionone merged pull request #358: Add console compilation verification
Posted by GitBox <gi...@apache.org>.
casionone merged PR #358:
URL: https://github.com/apache/incubator-linkis-website/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis-website] Beacontownfc commented on a diff in pull request #358: Add console compilation verification
Posted by GitBox <gi...@apache.org>.
Beacontownfc commented on code in PR #358:
URL: https://github.com/apache/incubator-linkis-website/pull/358#discussion_r904413805
##########
community/how-to-verify.md:
##########
@@ -156,7 +156,45 @@ $ mvnw.cmd -N install
#If the performance of the machine where the compilation is located is relatively poor, this process will be time-consuming, usually about 30min
$ mvnw.cmd clean install -Dmaven.javadoc.skip=true -Dmaven.test.skip=true
````
-#### 2.4.3 Check related compliance items
+#### 2.4.3 Console code compilation verification
+First check the files: web/package.json，web/.env, check whether the console version is correct
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis-website] casionone commented on a diff in pull request #358: Add console compilation verification
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #358:
URL: https://github.com/apache/incubator-linkis-website/pull/358#discussion_r903438322
##########
community/how-to-verify.md:
##########
@@ -156,7 +156,45 @@ $ mvnw.cmd -N install
#If the performance of the machine where the compilation is located is relatively poor, this process will be time-consuming, usually about 30min
$ mvnw.cmd clean install -Dmaven.javadoc.skip=true -Dmaven.test.skip=true
````
-#### 2.4.3 Check related compliance items
+#### 2.4.3 Console code compilation verification
+First check the files: web/package.json，web/.env, check whether the console version is correct
Review Comment:
en docs need to modify together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis-website] Beacontownfc commented on pull request #358: Add console compilation verification
Posted by GitBox <gi...@apache.org>.
Beacontownfc commented on PR #358:
URL: https://github.com/apache/incubator-linkis-website/pull/358#issuecomment-1159483488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org