You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2022/08/06 14:11:04 UTC
[couchdb] 18/21: doc(access): leave todo for missing implementation detail
This is an automated email from the ASF dual-hosted git repository.
jan pushed a commit to branch feat/access-2022
in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit d4691e0b60795c6a3e1c69f5353d0b047f05c47c
Author: Jan Lehnardt <ja...@apache.org>
AuthorDate: Sat Aug 6 12:52:17 2022 +0200
doc(access): leave todo for missing implementation detail
---
src/couch/src/couch_db.erl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/couch/src/couch_db.erl b/src/couch/src/couch_db.erl
index 6bcb21c12..dbf7a46aa 100644
--- a/src/couch/src/couch_db.erl
+++ b/src/couch/src/couch_db.erl
@@ -811,6 +811,8 @@ validate_access1(true, Db, #doc{meta=Meta}=Doc, Options) ->
_False -> validate_access2(Db, Doc)
end;
_Else -> % only admins can read conflicted docs in _access dbs
+ % TODO: expand: if leaves agree on _access, then a user should be able
+ % to proceed normally, only if they disagree should this become admin-only
case is_admin(Db) of
true -> ok;
_Else2 -> throw({forbidden, <<"document is in conflict">>})