You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "lklhdu (via GitHub)" <gi...@apache.org> on 2024/07/10 08:19:00 UTC

[PR] [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem [amoro]

lklhdu opened a new pull request, #3020:
URL: https://github.com/apache/amoro/pull/3020

   ## Why are the changes needed?
   Fix #3019.
   
   ## Brief change log
   - using Amoro TableMetaStore for kerberos authentication when read/write iceberg table
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / **no**)
   - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem [amoro]

Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 commented on PR #3020:
URL: https://github.com/apache/amoro/pull/3020#issuecomment-2233154399

   @lklhdu Thanks for your contribution. Could you add some unit tests to this section or running screenshots


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem [amoro]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3020:
URL: https://github.com/apache/amoro/pull/3020#issuecomment-2365368940

   This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem [amoro]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3020: [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem
URL: https://github.com/apache/amoro/pull/3020


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem [amoro]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3020:
URL: https://github.com/apache/amoro/pull/3020#issuecomment-2219877142

   ## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3020?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 27.58%. Comparing base [(`08183b7`)](https://app.codecov.io/gh/apache/amoro/commit/08183b7dffc066443e3b37eeddcfd07ff7079e69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`998078a`)](https://app.codecov.io/gh/apache/amoro/commit/998078aaaaaaae7c2f55ecddd2d99a6c6d5f25ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 15 commits behind head on master.
   
   > :exclamation:  There is a different number of reports uploaded between BASE (08183b7) and HEAD (998078a). Click for more details.
   > 
   > <details><summary>HEAD has 2 uploads less than BASE</summary>
   >
   >| Flag | BASE (08183b7) | HEAD (998078a) |
   >|------|------|------|
   >|core|2|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3020      +/-   ##
   ============================================
   - Coverage     32.85%   27.58%   -5.28%     
   + Complexity     3825     2484    -1341     
   ============================================
     Files           557      360     -197     
     Lines         46227    37117    -9110     
     Branches       6107     5372     -735     
   ============================================
   - Hits          15189    10237    -4952     
   + Misses        29843    25919    -3924     
   + Partials       1195      961     -234     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/amoro/pull/3020/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [core](https://app.codecov.io/gh/apache/amoro/pull/3020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [trino](https://app.codecov.io/gh/apache/amoro/pull/3020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.58% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3020?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem [amoro]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3020:
URL: https://github.com/apache/amoro/pull/3020#issuecomment-2351233553

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org