You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/30 11:15:30 UTC

[GitHub] [cloudstack] DK101010 opened a new pull request #5242: Add internal cs name to vm during the ingest

DK101010 opened a new pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242


   ### Description
   Each VM deployed in CS get an alphanumeric value as  internal CS name (cloud.vm.internal.name) . Each VM that will be ingested get no internal CS name and the internal name = VM name. 
   
   CS use for a couple of actions the internal CS name if exist and therefore CS can no longer update this properties. For an example power state.
   
   This PR add the internalCSName to VirtualMaschineMO and UnmanagedInstanceTO  inside the loadCache method to use this value  as instance name during the ingest. 
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Tested in own VMWare env.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-894789172


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890862661


   @shwstppr did you try other formats?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-898249334


   @blueorangutan test keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-895045091


   @blueorangutan test centos7 vmware-65u2
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#discussion_r686593157



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java
##########
@@ -579,8 +579,9 @@ private void loadVmCache() throws Exception {
 
                     if (s_logger.isTraceEnabled())
                         s_logger.trace("put " + vmName + " into host cache");
-
-                    _vmCache.put(vmName, new VirtualMachineMO(_context, oc.getObj()));
+                    VirtualMachineMO virtualMachine = new VirtualMachineMO(_context, oc.getObj());
+                    virtualMaschine.setInternalCSName(vmName);
+                    _vmCache.put(vmName, virtualMaschine);

Review comment:
       @DK101010 wrt previous commit variable name not changed here. This is causing build failures
   ```suggestion
                       virtualMachine.setInternalCSName(vmName);
                       _vmCache.put(vmName, virtualMachine);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890871260


   @DaanHoogland 
   
   - I've not debugged the reason but not all VMs have an internal name in vCenter in my env
   - I cloned a VM in vCenter. Cloned VM didn't have an internal name assigned though it had the property. 
   ![Screenshot from 2021-08-02 14-47-17](https://user-images.githubusercontent.com/153340/127837480-cb3a7fdd-caf1-491d-b690-31783ffbb34a.png)
   
   - I manually set the value there to `ak-cloned`
   ![Screenshot from 2021-08-02 14-48-45](https://user-images.githubusercontent.com/153340/127837138-631f5128-3937-4ddd-8086-3b9f2f1da25a.png)
   
   - Code didn't pick this value during import as the method `isUserVMInternalCSName` would return false. So after import `instance_name` in the vm_instance` table for the VM remained `cloned`
   ![Screenshot from 2021-08-02 13-51-36](https://user-images.githubusercontent.com/153340/127837210-fc79550a-eb66-4d61-8ce0-42e882134664.png)
   ![Screenshot from 2021-08-02 14-01-04](https://user-images.githubusercontent.com/153340/127837226-c78cb7cc-f396-4727-ba4b-5043cd82a878.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#discussion_r685944088



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java
##########
@@ -579,8 +579,9 @@ private void loadVmCache() throws Exception {
 
                     if (s_logger.isTraceEnabled())
                         s_logger.trace("put " + vmName + " into host cache");
-
-                    _vmCache.put(vmName, new VirtualMachineMO(_context, oc.getObj()));
+                    VirtualMachineMO virtualMaschine = new VirtualMachineMO(_context, oc.getObj());

Review comment:
       typo
   
   ```suggestion
                       VirtualMachineMO virtualMachine = new VirtualMachineMO(_context, oc.getObj());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-897625619


   <b>Trillian test result (tid-1602)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 79572 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5242-t1602-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 77 look OK, 12 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.12 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 420.57 | test_vpc_redundant.py
   test_02_VPC_default_routes | `Failure` | 975.94 | test_vpc_router_nics.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890769832


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-898617426


   <b>Trillian test result (tid-1627)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34809 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5242-t1627-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Smoke tests completed. 89 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896871993


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-894785829


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896469034


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890864532


   And, @shwstppr , what do you mean "when VM has internal name"? isn't it set during ingestion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-889823190


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian. SL-JID 710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-889834497


   @DK101010 can you please merge the latest `main` and fix the build issue
   ```
   [ERROR] /jenkins/workspace/acs-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.16.0.0-SNAPSHOT/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:[961,11] error: reference to StringUtils is ambiguous
   [ERROR]   both class org.apache.commons.lang3.StringUtils in org.apache.commons.lang3 and class org.apache.commons.lang.StringUtils in org.apache.commons.lang match
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890928799


   @blueorangutan test centos7 vmware-65u2
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-891493240


   <b>Trillian test result (tid-1451)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56458 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5242-t1451-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 74 look OK, 15 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 4.09 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 4.21 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.21 | test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.34 | test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.58 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.38 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.37 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.39 | test_iso.py
   test_04_extract_Iso | `Error` | 1.06 | test_iso.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   test_3d_gpu_support | `Error` | 1512.34 | test_deploy_vgpu_enabled_vm.py
   test_deploy_vm_from_iso | `Error` | 1511.87 | test_deploy_vm_iso.py
   test_list_vms_metrics | `Error` | 0.17 | test_metrics_api.py
   test_03_ping_in_ssvm_success | `Failure` | 60.19 | test_diagnostics.py
   test_08_arping_in_ssvm | `Failure` | 60.99 | test_diagnostics.py
   test_09_arping_in_cpvm | `Failure` | 61.18 | test_diagnostics.py
   test_11_traceroute_in_ssvm | `Failure` | 60.38 | test_diagnostics.py
   test_13_retrieve_vr_default_files | `Error` | 1.23 | test_diagnostics.py
   test_14_retrieve_vr_one_file | `Error` | 1.28 | test_diagnostics.py
   test_15_retrieve_ssvm_default_files | `Error` | 1.28 | test_diagnostics.py
   test_16_retrieve_ssvm_single_file | `Error` | 1.26 | test_diagnostics.py
   test_17_retrieve_cpvm_default_files | `Error` | 1.24 | test_diagnostics.py
   test_18_retrieve_cpvm_single_file | `Error` | 1.19 | test_diagnostics.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 95.68 | test_kubernetes_clusters.py
   test_nic_secondaryip_add_remove | `Failure` | 0.04 | test_multipleips_per_nic.py
   ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1373.69 | test_privategw_acl.py
   test_01_import_storage_policies | `Error` | 14.55 | test_storage_policy.py
   ContextSuite context=TestVMWareStoragePolicies>:teardown | `Error` | 14.58 | test_storage_policy.py
   test_03_delete_vm_snapshots | `Failure` | 273.23 | test_vm_snapshots.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-895045565


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-891493240


   <b>Trillian test result (tid-1451)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56458 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5242-t1451-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 74 look OK, 15 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 4.09 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 4.21 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.21 | test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.34 | test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.58 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.38 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.37 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.39 | test_iso.py
   test_04_extract_Iso | `Error` | 1.06 | test_iso.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   test_3d_gpu_support | `Error` | 1512.34 | test_deploy_vgpu_enabled_vm.py
   test_deploy_vm_from_iso | `Error` | 1511.87 | test_deploy_vm_iso.py
   test_list_vms_metrics | `Error` | 0.17 | test_metrics_api.py
   test_03_ping_in_ssvm_success | `Failure` | 60.19 | test_diagnostics.py
   test_08_arping_in_ssvm | `Failure` | 60.99 | test_diagnostics.py
   test_09_arping_in_cpvm | `Failure` | 61.18 | test_diagnostics.py
   test_11_traceroute_in_ssvm | `Failure` | 60.38 | test_diagnostics.py
   test_13_retrieve_vr_default_files | `Error` | 1.23 | test_diagnostics.py
   test_14_retrieve_vr_one_file | `Error` | 1.28 | test_diagnostics.py
   test_15_retrieve_ssvm_default_files | `Error` | 1.28 | test_diagnostics.py
   test_16_retrieve_ssvm_single_file | `Error` | 1.26 | test_diagnostics.py
   test_17_retrieve_cpvm_default_files | `Error` | 1.24 | test_diagnostics.py
   test_18_retrieve_cpvm_single_file | `Error` | 1.19 | test_diagnostics.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 95.68 | test_kubernetes_clusters.py
   test_nic_secondaryip_add_remove | `Failure` | 0.04 | test_multipleips_per_nic.py
   ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1373.69 | test_privategw_acl.py
   test_01_import_storage_policies | `Error` | 14.55 | test_storage_policy.py
   ContextSuite context=TestVMWareStoragePolicies>:teardown | `Error` | 14.58 | test_storage_policy.py
   test_03_delete_vm_snapshots | `Failure` | 273.23 | test_vm_snapshots.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896872497


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-894785977


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896478551


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890804973


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890770125


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896645032


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-889820075


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-889819917


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896478860


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896625791


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896468819


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-898249550


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896483591


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian. SL-JID 836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#discussion_r677478661



##########
File path: server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
##########
@@ -954,6 +955,11 @@ private UserVm importVirtualMachineInternal(final UnmanagedInstanceTO unmanagedI
             throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, String.format("Failed to import VM: %s. %s", unmanagedInstance.getName(), Strings.nullToEmpty(e.getMessage())));
         }
 
+        String internalCSName = instanceName;
+        if(!StringUtils.isEmpty(unmanagedInstance.getInternalCSName()) && !unmanagedInstance.getInternalCSName().equals(instanceName)){
+            internalCSName = unmanagedInstance.getInternalCSName();
+        }
+

Review comment:
       bit less to read like this;
   ```suggestion
           String internalCSName = unmanagedInstance.getInternalCSName();
           if(StringUtils.isEmpty(internalCSName)){
               internalCSName = instanceName;
           }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890929318


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#discussion_r686593157



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java
##########
@@ -579,8 +579,9 @@ private void loadVmCache() throws Exception {
 
                     if (s_logger.isTraceEnabled())
                         s_logger.trace("put " + vmName + " into host cache");
-
-                    _vmCache.put(vmName, new VirtualMachineMO(_context, oc.getObj()));
+                    VirtualMachineMO virtualMachine = new VirtualMachineMO(_context, oc.getObj());
+                    virtualMaschine.setInternalCSName(vmName);
+                    _vmCache.put(vmName, virtualMaschine);

Review comment:
       @DK101010 wrt previous commit variable name not changed here. This is causing build failures




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896626121


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-896478171


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian. SL-JID 835


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr closed pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5242: Add internal cs name to vm during the ingest

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5242:
URL: https://github.com/apache/cloudstack/pull/5242#issuecomment-890874179


   @DaanHoogland I think @DK101010 wants to fix the case where a CloudStack VM is unmanaged and then imported again it gets the correct instance name. In that case unmanaged VM will already have an internal name set. During import no change is made to `cloud.vm.internal.name` property


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org