You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sumitagrawl (via GitHub)" <gi...@apache.org> on 2025/09/15 10:10:34 UTC
[PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
sumitagrawl opened a new pull request, #9038:
URL: https://github.com/apache/ozone/pull/9038
## What changes were proposed in this pull request?
Provide a one-liner summary of the changes in the PR **Title** field above.
It should be in the form of `HDDS-1234. Short summary of the change`.
Please describe your PR in detail:
* What changes are proposed in the PR? and Why? It would be better if it is written from third person's
perspective not just for the reviewer.
* Provide as much context and rationale for the pull request as possible. It could be copy-paste from
the Jira's description if the jira is well defined.
* If it is complex code, describe the approach used to solve the issue. If possible attach design doc,
issue investigation, github discussion, etc.
Examples of well-written pull requests:
* [#3980](https://github.com/apache/ozone/pull/3980)
* [#5265](https://github.com/apache/ozone/pull/5265)
* [#4701](https://github.com/apache/ozone/pull/4701)
* [#5283](https://github.com/apache/ozone/pull/5283)
* [#5300](https://github.com/apache/ozone/pull/5300)
## What is the link to the Apache JIRA
Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull
request which starts with the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
(Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2363384754
##########
hadoop-hdds/docs/content/feature/Observability.md:
##########
@@ -97,8 +97,8 @@ Repeat the same for [Object Metrics](https://raw.githubusercontent.com/apache/oz
## Distributed tracing
Distributed tracing can help to understand performance bottleneck with visualizing end-to-end performance.
-
-Ozone uses [jaeger](https://jaegertracing.io) tracing library to collect traces which can send tracing data to any compatible backend (Zipkin, ...).
+Ozone makes use of [OpenTelemetry](https://opentelemetry.io/) API for tracing and uses otlp with Grpc format for sending traces.
Review Comment:
Optional, but maybe we can also mention Ozone migrated from OpenTracing to OpenTelemetry in 2.1 (?) for historical context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2354479033
##########
hadoop-hdds/common/pom.xml:
##########
@@ -68,16 +68,34 @@
<artifactId>picocli</artifactId>
</dependency>
<dependency>
- <groupId>io.jaegertracing</groupId>
- <artifactId>jaeger-core</artifactId>
+ <groupId>io.opentelemetry</groupId>
+ <artifactId>opentelemetry-api</artifactId>
+ <version>${opentelemetry.version}</version>
Review Comment:
Please remove `<version>` from all submodule POM files. It is inherited from root POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9038:
URL: https://github.com/apache/ozone/pull/9038#issuecomment-3300887774
@sumitagrawl Haven't taken a look in details, but FYI please kindly reflect any changes in "Distributed Tracing" documentation (https://ozone.apache.org/docs/edge/feature/observability.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2363348922
##########
hadoop-hdds/docs/content/feature/Observability.md:
##########
@@ -109,17 +109,15 @@ Tracing is turned off by default, but can be turned on with `hdds.tracing.enable
</property>
```
-Jaeger client can be configured with environment variables as documented [here](https://github.com/jaegertracing/jaeger-client-java/blob/master/jaeger-core/README.md):
-
-For example:
+Below are the configuration to be done to provide collector endpoint and sampling strategy. These are environment variables to be set for each Ozone component (OM, SCM, datanode)
Review Comment:
Just a little suggestion to the text
```suggestion
Below are the configuration steps for setting the collector endpoint and sampling strategy. Set these environment variables for each Ozone component (OM, SCM, datanode) and for the Ozone client to enable tracing.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on PR #9038:
URL: https://github.com/apache/ozone/pull/9038#issuecomment-3312786280
> From a quick look it looks good. Thanks @sumitagrawl Just a trivial text suggestion.
>
> Client applications such as HBase support OpenTelemetry. I wonder if the traces started from HBase can connect correctly to the underlying Ozone traces. I couldn't get it working when Ozone was using OpenTracing.
Yes, it will able to trace. Few improvement JIRA to be raised for details, I have prepared design doc for the same,
https://github.com/apache/ozone/pull/9051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2355949547
##########
hadoop-hdds/common/pom.xml:
##########
@@ -68,16 +68,34 @@
<artifactId>picocli</artifactId>
</dependency>
<dependency>
- <groupId>io.jaegertracing</groupId>
- <artifactId>jaeger-core</artifactId>
+ <groupId>io.opentelemetry</groupId>
+ <artifactId>opentelemetry-api</artifactId>
+ <version>${opentelemetry.version}</version>
Review Comment:
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2363456850
##########
hadoop-hdds/docs/content/feature/Observability.md:
##########
@@ -97,8 +97,8 @@ Repeat the same for [Object Metrics](https://raw.githubusercontent.com/apache/oz
## Distributed tracing
Distributed tracing can help to understand performance bottleneck with visualizing end-to-end performance.
-
-Ozone uses [jaeger](https://jaegertracing.io) tracing library to collect traces which can send tracing data to any compatible backend (Zipkin, ...).
+Ozone makes use of [OpenTelemetry](https://opentelemetry.io/) API for tracing and uses otlp with Grpc format for sending traces.
Review Comment:
I will mention this in release note of JIRA as changes as right place for change record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl merged PR #9038:
URL: https://github.com/apache/ozone/pull/9038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2355640216
##########
hadoop-hdds/common/pom.xml:
##########
@@ -68,16 +68,34 @@
<artifactId>picocli</artifactId>
</dependency>
<dependency>
- <groupId>io.jaegertracing</groupId>
- <artifactId>jaeger-core</artifactId>
+ <groupId>io.opentelemetry</groupId>
+ <artifactId>opentelemetry-api</artifactId>
+ <version>${opentelemetry.version}</version>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13680. migrate tracing to opentelemetry [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #9038:
URL: https://github.com/apache/ozone/pull/9038#discussion_r2363465083
##########
hadoop-hdds/docs/content/feature/Observability.md:
##########
@@ -109,17 +109,15 @@ Tracing is turned off by default, but can be turned on with `hdds.tracing.enable
</property>
```
-Jaeger client can be configured with environment variables as documented [here](https://github.com/jaegertracing/jaeger-client-java/blob/master/jaeger-core/README.md):
-
-For example:
+Below are the configuration to be done to provide collector endpoint and sampling strategy. These are environment variables to be set for each Ozone component (OM, SCM, datanode)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org