You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2018/07/24 10:10:53 UTC
lucene-solr:master: LUCENE-8412: Fix TestDistributedGrouping failure.
Repository: lucene-solr
Updated Branches:
refs/heads/master 8892c0d9a -> d010cdd87
LUCENE-8412: Fix TestDistributedGrouping failure.
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/d010cdd8
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/d010cdd8
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/d010cdd8
Branch: refs/heads/master
Commit: d010cdd87eec89bf6308351b817d9ec1d5c6e14e
Parents: 8892c0d
Author: Adrien Grand <jp...@gmail.com>
Authored: Tue Jul 24 12:10:25 2018 +0200
Committer: Adrien Grand <jp...@gmail.com>
Committed: Tue Jul 24 12:10:25 2018 +0200
----------------------------------------------------------------------
.../grouping/distributed/command/TopGroupsFieldCommand.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/d010cdd8/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java b/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
index 3902841..b618286 100644
--- a/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
+++ b/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
@@ -173,8 +173,10 @@ public class TopGroupsFieldCommand implements Command<TopGroups<BytesRef>> {
} else {
topGroups = secondPassCollector.getTopGroups(0);
}
- for (GroupDocs<?> group : topGroups.groups) {
- TopFieldCollector.populateScores(group.scoreDocs, searcher, query);
+ if (needScores) {
+ for (GroupDocs<?> group : topGroups.groups) {
+ TopFieldCollector.populateScores(group.scoreDocs, searcher, query);
+ }
}
}