You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nikhil Bonte <ni...@freestoneinfotech.com> on 2019/08/29 13:31:27 UTC
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/
-----------------------------------------------------------
(Updated Aug. 29, 2019, 1:31 p.m.)
Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3387
https://issues.apache.org/jira/browse/ATLAS-3387
Repository: atlas
Description
-------
Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
Diffs
-----
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 54f7330da
Diff: https://reviews.apache.org/r/71406/diff/5/
Testing
-------
Tested with simple authorizer. Need to test after ranger end changes.
Thanks,
Nikhil Bonte
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/#review217525
-----------------------------------------------------------
Fix it, then Ship it!
server-api/src/main/java/org/apache/atlas/RequestContext.java
Lines 364 (patched)
<https://reviews.apache.org/r/71406/#comment304785>
Is it necessary to handle 'null' as a special value here? Caller of getForwardedAddresses() will have to deal with null return anyway, since setForwardedAddresses() need not be called. I suggest to simply set this.forwardedAddresses to the given value.
- Madhan Neethiraj
On Aug. 29, 2019, 1:31 p.m., Nikhil Bonte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71406/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2019, 1:31 p.m.)
>
>
> Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3387
> https://issues.apache.org/jira/browse/ATLAS-3387
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
> server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3
> webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 54f7330da
>
>
> Diff: https://reviews.apache.org/r/71406/diff/5/
>
>
> Testing
> -------
>
> Tested with simple authorizer. Need to test after ranger end changes.
>
>
> Thanks,
>
> Nikhil Bonte
>
>
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/#review217646
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Sept. 9, 2019, 5:32 a.m., Nikhil Bonte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71406/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2019, 5:32 a.m.)
>
>
> Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3387
> https://issues.apache.org/jira/browse/ATLAS-3387
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAdminAccessRequest.java 1782b3272
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java 07ff678ed
> authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java d2da03c1a
> authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java c908b28a7
> authorization/src/main/java/org/apache/atlas/authorize/AtlasTypeAccessRequest.java af38425fb
> server-api/src/main/java/org/apache/atlas/RequestContext.java 0c3ba08df
> webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java e9c44b336
>
>
> Diff: https://reviews.apache.org/r/71406/diff/8/
>
>
> Testing
> -------
>
> Tested with simple authorizer. Need to test after ranger end changes.
>
>
> Thanks,
>
> Nikhil Bonte
>
>
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Nikhil Bonte <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/
-----------------------------------------------------------
(Updated Sept. 9, 2019, 5:32 a.m.)
Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Resolved merge issue.
Bugs: ATLAS-3387
https://issues.apache.org/jira/browse/ATLAS-3387
Repository: atlas
Description
-------
Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
Diffs (updated)
-----
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
authorization/src/main/java/org/apache/atlas/authorize/AtlasAdminAccessRequest.java 1782b3272
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java 07ff678ed
authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java d2da03c1a
authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java c908b28a7
authorization/src/main/java/org/apache/atlas/authorize/AtlasTypeAccessRequest.java af38425fb
server-api/src/main/java/org/apache/atlas/RequestContext.java 0c3ba08df
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java e9c44b336
Diff: https://reviews.apache.org/r/71406/diff/8/
Changes: https://reviews.apache.org/r/71406/diff/7-8/
Testing
-------
Tested with simple authorizer. Need to test after ranger end changes.
Thanks,
Nikhil Bonte
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/#review217610
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 6, 2019, 10:10 a.m., Nikhil Bonte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71406/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2019, 10:10 a.m.)
>
>
> Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3387
> https://issues.apache.org/jira/browse/ATLAS-3387
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAdminAccessRequest.java 1782b3272
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java 07ff678ed
> authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java d2da03c1a
> authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java c908b28a7
> authorization/src/main/java/org/apache/atlas/authorize/AtlasTypeAccessRequest.java af38425fb
> server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3
> webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 54f7330da
>
>
> Diff: https://reviews.apache.org/r/71406/diff/7/
>
>
> Testing
> -------
>
> Tested with simple authorizer. Need to test after ranger end changes.
>
>
> Thanks,
>
> Nikhil Bonte
>
>
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Nikhil Bonte <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/
-----------------------------------------------------------
(Updated Sept. 6, 2019, 10:10 a.m.)
Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed open issue.
Bugs: ATLAS-3387
https://issues.apache.org/jira/browse/ATLAS-3387
Repository: atlas
Description
-------
Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
Diffs (updated)
-----
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
authorization/src/main/java/org/apache/atlas/authorize/AtlasAdminAccessRequest.java 1782b3272
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java 07ff678ed
authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java d2da03c1a
authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java c908b28a7
authorization/src/main/java/org/apache/atlas/authorize/AtlasTypeAccessRequest.java af38425fb
server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 54f7330da
Diff: https://reviews.apache.org/r/71406/diff/7/
Changes: https://reviews.apache.org/r/71406/diff/6-7/
Testing
-------
Tested with simple authorizer. Need to test after ranger end changes.
Thanks,
Nikhil Bonte
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/#review217596
-----------------------------------------------------------
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
Lines 104 (patched)
<https://reviews.apache.org/r/71406/#comment304868>
Lines #104, #105 should be added for other AccessRequest types as well, for example at: #83, #130, #155, #180
- Madhan Neethiraj
On Sept. 5, 2019, 10:23 a.m., Nikhil Bonte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71406/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2019, 10:23 a.m.)
>
>
> Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3387
> https://issues.apache.org/jira/browse/ATLAS-3387
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
> server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3
> webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 54f7330da
>
>
> Diff: https://reviews.apache.org/r/71406/diff/6/
>
>
> Testing
> -------
>
> Tested with simple authorizer. Need to test after ranger end changes.
>
>
> Thanks,
>
> Nikhil Bonte
>
>
Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header
for getting end user IP address when connected with proxy
Posted by Nikhil Bonte <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71406/
-----------------------------------------------------------
(Updated Sept. 5, 2019, 10:23 a.m.)
Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed open issue.
Bugs: ATLAS-3387
https://issues.apache.org/jira/browse/ATLAS-3387
Repository: atlas
Description
-------
Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy
Diffs (updated)
-----
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java b031f4c3e
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java ac2f52525
server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 54f7330da
Diff: https://reviews.apache.org/r/71406/diff/6/
Changes: https://reviews.apache.org/r/71406/diff/5-6/
Testing
-------
Tested with simple authorizer. Need to test after ranger end changes.
Thanks,
Nikhil Bonte