You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/09 06:21:12 UTC

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #4057: [runtime] Replace the thread pool in FragmentMgr

vagetablechicken opened a new pull request #4057:
URL: https://github.com/apache/incubator-doris/pull/4057


   Ref https://github.com/apache/incubator-doris/issues/3416
   Thread pool submit func may return error. To support error handling, we need add cancel_before_execute() for it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] vagetablechicken commented on pull request #4057: [runtime] Replace the thread pool in FragmentMgr

Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on pull request #4057:
URL: https://github.com/apache/incubator-doris/pull/4057#issuecomment-657407295


   > If you replace PriorityThreadPool with util/threadpool.h, I suggest you set fragment_pool_queue_size larger. Because There will be thousands of qps in dashboard reporting. You can double the default value to 2048.
   
   fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] chaoyli commented on pull request #4057: [runtime] Replace the thread pool in FragmentMgr

Posted by GitBox <gi...@apache.org>.
chaoyli commented on pull request #4057:
URL: https://github.com/apache/incubator-doris/pull/4057#issuecomment-656979162


   If you replace PriorityThreadPool with util/threadpool.h, I suggest you set fragment_pool_queue_size larger. Because There will be thousands of qps in dashboard reporting. You can double the default value to 2048.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] chaoyli merged pull request #4057: [runtime] Replace the thread pool in FragmentMgr

Posted by GitBox <gi...@apache.org>.
chaoyli merged pull request #4057:
URL: https://github.com/apache/incubator-doris/pull/4057


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org