[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5437: [Core | Spark | Integrations] : Fix kryo serialization failure for FileIO

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #5437:
URL: https://github.com/apache/iceberg/pull/5437#discussion_r961061975


##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/TestFileIOSerialization.java:
##########
@@ -101,6 +104,60 @@ public void testHadoopFileIOJavaSerialization() throws IOException, ClassNotFoun
     Assert.assertEquals("Conf values must be present", "v2", actualConf.get("k2"));
   }
 
+  @Test

Review Comment:
   Agree with you, i left it here as I wanted to have a test with spark e2e, but what it's testing is not different from what we have already tested in their respective modules. Have removed them. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org