You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/18 02:21:32 UTC

[GitHub] [arrow] chrisirhc opened a new issue, #33734: [Go] arrow library is not compatible with grpc < 1.45 due to use of reflection experimental interface

chrisirhc opened a new issue, #33734:
URL: https://github.com/apache/arrow/issues/33734

   ### Describe the enhancement requested
   
   When attempting to use arrow library in projects with grpc < 1.45, the reflection was added in v1.45.0 via https://github.com/grpc/grpc-go/commit/18564ff61d5505d955c7bd1adc28e4f1ed96300c . 
   
   This is due to a single line that references an experimental interface in grpc.reflection package:
   https://github.com/apache/arrow/blob/c8d6110a26c41966e539e9fa2f5cb8c31dc2f0fe/go/arrow/flight/server.go#L97-L99
   
   The interface is defined as:
   https://github.com/grpc/grpc-go/blob/4c776ec01572d55249df309251900554b46adb41/reflection/serverreflection.go#L69-L83
   
   I propose to inline this interface so that the go arrow library can be used in projects with earlier versions of grpc which don't contain this experimental interface. This should maintain the reflection capabilities introduced in https://github.com/apache/arrow/commit/07e7009154dc64967543ccd6462841443a8586b7 but make go arrow library compatible with grpc < 1.45.
   
   ### Component(s)
   
   Go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] zeroshade closed issue #33734: [Go] arrow library is not compatible with grpc < 1.45 due to use of reflection experimental interface

Posted by GitBox <gi...@apache.org>.
zeroshade closed issue #33734: [Go] arrow library is not compatible with grpc < 1.45 due to use of reflection experimental interface
URL: https://github.com/apache/arrow/issues/33734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] zeroshade commented on issue #33734: [Go] arrow library is not compatible with grpc < 1.45 due to use of reflection experimental interface

Posted by GitBox <gi...@apache.org>.
zeroshade commented on issue #33734:
URL: https://github.com/apache/arrow/issues/33734#issuecomment-1397705414

   Issue resolved by pull request 33735
   https://github.com/apache/arrow/pull/33735


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] assignUser commented on issue #33734: [Go] arrow library is not compatible with grpc < 1.45 due to use of reflection experimental interface

Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #33734:
URL: https://github.com/apache/arrow/issues/33734#issuecomment-1386381435

   cc @zeroshade 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org