You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/04/28 14:52:45 UTC

[commons-beanutils] 09/23: Remove unused parameter.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit 6de63e687de51fc705b25818e8911fc78a0eb3d3
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Apr 27 14:55:13 2022 -0400

    Remove unused parameter.
---
 .../apache/commons/beanutils2/converters/ArrayConverter.java | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java b/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java
index dee30a69..51e238c2 100644
--- a/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/converters/ArrayConverter.java
@@ -362,7 +362,7 @@ public class ArrayConverter<C> extends AbstractConverter<C> {
             return list;
         }
 
-        return parseElements(type, value.toString());
+        return parseElements(value.toString());
     }
 
     /**
@@ -417,9 +417,8 @@ public class ArrayConverter<C> extends AbstractConverter<C> {
      * <li>Elements in the list may be delimited by single or double quotes.
      *  Within a quoted elements, the normal Java escape sequences are valid.</li>
      * </ul>
-     *
-     * @param type The type to convert the value to
      * @param value String value to be parsed
+     *
      * @return List of parsed elements.
      *
      * @throws ConversionException if the syntax of {@code value}
@@ -427,7 +426,7 @@ public class ArrayConverter<C> extends AbstractConverter<C> {
      * @throws NullPointerException if {@code value}
      *  is {@code null}
      */
-    private List<String> parseElements(final Class<?> type, String value) {
+    private List<String> parseElements(String value) {
         if (log().isDebugEnabled()) {
             log().debug("Parsing elements, delimiter=[" + delimiter + "], value=[" + value + "]");
         }
@@ -438,6 +437,7 @@ public class ArrayConverter<C> extends AbstractConverter<C> {
             value = value.substring(1, value.length() - 1);
         }
 
+        final String typeName = toString(String.class);
         try {
 
             // Set up a StreamTokenizer on the characters in this String
@@ -465,7 +465,7 @@ public class ArrayConverter<C> extends AbstractConverter<C> {
                     break;
                 } else {
                     throw new ConversionException("Encountered token of type "
-                        + ttype + " parsing elements to '" + toString(type) + ".");
+                        + ttype + " parsing elements to '" + typeName + ".");
                 }
             }
 
@@ -481,7 +481,7 @@ public class ArrayConverter<C> extends AbstractConverter<C> {
 
         } catch (final IOException e) {
             throw new ConversionException("Error converting from String to '"
-                    + toString(type) + "': " + e.getMessage(), e);
+                    + typeName + "': " + e.getMessage(), e);
         }
     }