You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/01/05 11:59:03 UTC
Review Request 64975: ATLAS-2339 : UI : Modifications in "columns" in
Basic search result view affects DSL also.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64975/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
Bugs: ATLAS-2339
https://issues.apache.org/jira/browse/ATLAS-2339
Repository: atlas
Description
-------
1.Fire a basic query , ex : type = hive_table .
2.Switch to DSL , fire the same type=hive_table.
3.Switch back to basic. Deselect "Type" from columns.
4.Switch to DSL. DSL query is fired again. This time "Type" column is not found in UI of DSL search results.
Diffs
-----
dashboardv2/public/js/views/search/SearchResultLayoutView.js 81816f3
Diff: https://reviews.apache.org/r/64975/diff/1/
Testing
-------
Done one round of sanity testing.
Thanks,
pratik pandey
Re: Review Request 64975: ATLAS-2339 : UI : Modifications in
"columns" in Basic search result view affects DSL also.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64975/#review194935
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 5, 2018, 11:59 a.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64975/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 11:59 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
>
>
> Bugs: ATLAS-2339
> https://issues.apache.org/jira/browse/ATLAS-2339
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1.Fire a basic query , ex : type = hive_table .
> 2.Switch to DSL , fire the same type=hive_table.
> 3.Switch back to basic. Deselect "Type" from columns.
> 4.Switch to DSL. DSL query is fired again. This time "Type" column is not found in UI of DSL search results.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 81816f3
>
>
> Diff: https://reviews.apache.org/r/64975/diff/1/
>
>
> Testing
> -------
>
> Done one round of sanity testing.
>
>
> Thanks,
>
> pratik pandey
>
>