You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2019/02/27 20:27:32 UTC

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() 

Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12623


Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()
......................................................................

IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

An incoming request to a RPC service can be rejected either due
to exceeding the memory limit or maximum allowed queue length.
It's unclear from the current error message which of those factors
contributes to the failure as neither the actual queue length nor
the memory consumption is printed.

This patch fixes the problem by printing the estimated queue length
and memory consumption when a RPC request is dropped.

Change-Id: I5b40b8e2077b61e2f7e244b87c946f30803438bc
---
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
2 files changed, 7 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/12623/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b40b8e2077b61e2f7e244b87c946f30803438bc
Gerrit-Change-Number: 12623
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/12623 )

Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/12623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5b40b8e2077b61e2f7e244b87c946f30803438bc
Gerrit-Change-Number: 12623
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12623 )

Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2279/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b40b8e2077b61e2f7e244b87c946f30803438bc
Gerrit-Change-Number: 12623
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 20:59:04 +0000
Gerrit-HasComments: No