You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 07:59:20 UTC

[GitHub] [arrow] thisisnic commented on a change in pull request #11901: ARROW-14849: [R] Update messaging in installation scripts

thisisnic commented on a change in pull request #11901:
URL: https://github.com/apache/arrow/pull/11901#discussion_r765509452



##########
File path: r/tools/nixlibs.R
##########
@@ -600,12 +600,15 @@ if (!file.exists(paste0(dst_dir, "/include/arrow/api.h"))) {
     # (2) Find source and build it
     src_dir <- find_local_source()
     if (!is.null(src_dir)) {
-      cat("*** Building C++ libraries\n")
+      cat("*** Building libarrow\n")
+      cat("*** For a faster installation, set the environment variable LIBARROW_BINARY=true before installing\n")
+      cat("*** Not all features are enabled by default.")
+      cat("    For a fully-featured installation, set the environment variable LIBARROW_MINIMAL=false before installing\n")

Review comment:
       Yeah, I was wanting to be more explicit about the multiple things which were going on, but I think we can get the best of both worlds by referring to `NOT_CRAN` and then suggesting the user takes a look at the install vignette for more info, like we do in another place in the script.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org