[jira] [Commented] (HDFS-16622) addRDBI in IncrementalBlockReportManager may remove the block with bigger GS.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18037301#comment-18037301 ] 

ASF GitHub Bot commented on HDFS-16622:
---------------------------------------

github-actions[bot] commented on PR #4407:
URL: https://github.com/apache/hadoop/pull/4407#issuecomment-3514459693

   We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
   Thanks all for your contribution.




> addRDBI in IncrementalBlockReportManager may remove the block with bigger GS.
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-16622
>                 URL: https://issues.apache.org/jira/browse/HDFS-16622
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In our production environment,  there is a strange missing block, according to the log, I suspect there is a bug in function addRDBI(ReceivedDeletedBlockInfo rdbi,DatanodeStorage storage)(line 250).
> Bug code in the for loop:
> {code:java}
> synchronized void addRDBI(ReceivedDeletedBlockInfo rdbi,
>       DatanodeStorage storage) {
>     // Make sure another entry for the same block is first removed.
>     // There may only be one such entry.
>     for (PerStorageIBR perStorage : pendingIBRs.values()) {
>       if (perStorage.remove(rdbi.getBlock()) != null) {
>         break;
>       }
>     }
>     getPerStorageIBR(storage).put(rdbi);
>   }
> {code}
> Removed the GS of the Block in ReceivedDeletedBlockInfo may be greater than the GS of the Block in rdbi. And NN will invalidate the Replicate will small GS when complete one block. 
> So If there is only one replicate for one block, there is a possibility of missingblock because of this wrong logic. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org