[jira] [Commented] (TEZ-983) Support a helper function to extract required additional tokens from a file

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950404#comment-13950404 ] 

Siddharth Seth commented on TEZ-983:
------------------------------------

{code}
+      binary = Credentials.readTokenStorageFile(
+          new Path("file:///" +  tokenFilePath), conf);
{code}
indentation fix needed.

{code}
public static void getMRBinaryTokens(Credentials creds,
{code}
Rename to mergeMRBinaryTokens ? or return a new Credential instance instead of accepting one as a parameter ?

Otherwise looks good.


> Support a helper function to extract required additional tokens from a file
> ---------------------------------------------------------------------------
>
>                 Key: TEZ-983
>                 URL: https://issues.apache.org/jira/browse/TEZ-983
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-983.1.patch
>
>
> Oozie, etc that use Hive/Pig indirectly provide tokens to downstream applications by writing them into a file and expect the downstream application to read and use them.
> Support a helper function for the above.



--
This message was sent by Atlassian JIRA
(v6.2#6252)