You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2024/01/27 09:26:46 UTC
[PR] [fix](regex) use boost::regex instead of std:: [doris]
dataroaring opened a new pull request, #30461:
URL: https://github.com/apache/doris/pull/30461
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #30461:
URL: https://github.com/apache/doris/pull/30461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913093991
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913107398
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 0f5eb448c91a2689abd022c12cd733ff5d38313d with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.1 seconds inserted 10000000 Rows, about 473K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913092265
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913093343
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913094396
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913106673
<details>
<summary>ClickBench: <b>Total hot run time: 30.32 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0f5eb448c91a2689abd022c12cd733ff5d38313d, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.03 0.02
query3 0.24 0.05 0.06
query4 1.82 0.06 0.06
query5 0.52 0.52 0.52
query6 1.24 0.62 0.62
query7 0.01 0.01 0.01
query8 0.03 0.02 0.03
query9 0.52 0.47 0.48
query10 0.54 0.54 0.53
query11 0.11 0.09 0.08
query12 0.11 0.08 0.09
query13 0.62 0.61 0.63
query14 0.78 0.79 0.81
query15 0.79 0.76 0.76
query16 0.36 0.37 0.36
query17 1.01 1.02 1.00
query18 0.22 0.25 0.25
query19 1.92 1.86 1.86
query20 0.01 0.01 0.01
query21 16.01 0.60 0.55
query22 2.07 2.76 1.37
query23 17.37 1.02 0.95
query24 4.91 0.64 2.99
query25 2.18 0.16 0.15
query26 0.15 0.13 0.15
query27 0.14 0.16 0.14
query28 7.35 0.72 0.71
query29 12.62 2.27 2.36
query30 0.53 0.50 0.50
query31 2.82 0.38 0.38
query32 3.44 0.50 0.49
query33 3.11 3.05 3.09
query34 15.25 4.80 4.79
query35 4.84 4.83 4.85
query36 1.05 1.01 1.00
query37 0.05 0.04 0.05
query38 0.03 0.02 0.02
query39 0.02 0.01 0.02
query40 0.16 0.14 0.14
query41 0.06 0.01 0.02
query42 0.02 0.01 0.01
query43 0.02 0.02 0.02
Total cold run time: 105.13 s
Total hot run time: 30.32 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913101754
<details>
<summary>TPC-H: <b>Total hot run time: 49863 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f5eb448c91a2689abd022c12cd733ff5d38313d, data reload: false
------ Round 1 ----------------------------------
q1 17876 4398 4358 4358
q2 2020 149 137 137
q3 10471 1880 1917 1880
q4 10322 1239 1290 1239
q5 8335 3918 3913 3913
q6 226 121 122 121
q7 2020 1610 1602 1602
q8 9259 2701 2701 2701
q9 10777 10425 10308 10308
q10 8611 3504 3523 3504
q11 419 238 242 238
q12 457 298 298 298
q13 18345 3987 4055 3987
q14 342 330 318 318
q15 506 448 450 448
q16 718 591 599 591
q17 1109 947 961 947
q18 7202 6925 7033 6925
q19 1661 1568 1564 1564
q20 514 302 312 302
q21 4435 4084 4089 4084
q22 510 398 403 398
Total cold run time: 116135 ms
Total hot run time: 49863 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4339 4267 4289 4267
q2 319 219 238 219
q3 4151 4152 4132 4132
q4 2748 2726 2725 2725
q5 7221 7147 7165 7147
q6 233 116 117 116
q7 3257 2855 2923 2855
q8 4348 4494 4515 4494
q9 17070 17003 17034 17003
q10 4225 4294 4220 4220
q11 768 676 664 664
q12 1015 848 851 848
q13 6729 3708 3749 3708
q14 453 425 411 411
q15 489 452 460 452
q16 750 698 706 698
q17 3859 3863 3814 3814
q18 8828 8717 8769 8717
q19 1705 1686 1705 1686
q20 2378 2170 2136 2136
q21 8601 8507 8497 8497
q22 1034 986 969 969
Total cold run time: 84520 ms
Total hot run time: 79778 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913105411
<details>
<summary>TPC-DS: <b>Total hot run time: 238588 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f5eb448c91a2689abd022c12cd733ff5d38313d, data reload: false
query1 932 394 389 389
query2 6543 2181 2091 2091
query3 6915 199 196 196
query4 20000 18017 17923 17923
query5 19724 6240 6204 6204
query6 286 216 223 216
query7 4143 301 296 296
query8 245 243 246 243
query9 3055 2653 2583 2583
query10 408 301 305 301
query11 11227 10751 10762 10751
query12 129 78 72 72
query13 5650 644 614 614
query14 17251 13280 13122 13122
query15 355 233 247 233
query16 6453 269 272 269
query17 3175 863 858 858
query18 2266 409 405 405
query19 209 145 147 145
query20 78 74 74 74
query21 191 91 89 89
query22 5463 5183 5180 5180
query23 32470 31882 31780 31780
query24 7018 6667 6506 6506
query25 533 425 411 411
query26 528 158 160 158
query27 1900 298 290 290
query28 6040 2199 2153 2153
query29 2839 2650 2789 2650
query30 244 166 163 163
query31 882 762 758 758
query32 63 57 57 57
query33 389 238 246 238
query34 836 463 475 463
query35 1114 924 915 915
query36 1519 1376 1541 1376
query37 92 58 61 58
query38 3142 2921 2956 2921
query39 1354 1325 1311 1311
query40 210 90 97 90
query41 35 32 32 32
query42 91 84 85 84
query43 605 646 580 580
query44 1124 706 702 702
query45 239 228 226 226
query46 1238 934 961 934
query47 1770 1712 1786 1712
query48 966 671 674 671
query49 602 362 364 362
query50 853 619 579 579
query51 5640 5499 5452 5452
query52 91 79 82 79
query53 451 318 315 315
query54 2425 2208 2207 2207
query55 77 84 75 75
query56 202 194 202 194
query57 1174 1075 1085 1075
query58 212 201 186 186
query59 3513 3209 3427 3209
query60 209 185 193 185
query61 86 90 86 86
query62 758 472 585 472
query63 474 321 329 321
query64 2003 1332 1315 1315
query65 3692 3587 3597 3587
query66 820 362 360 360
query67 17068 15651 17064 15651
query68 5821 629 661 629
query69 547 329 352 329
query70 1696 1618 1595 1595
query71 394 294 313 294
query72 4475 3358 3386 3358
query73 706 317 315 315
query74 6337 5938 5842 5842
query75 4243 3524 3453 3453
query76 3528 1174 1216 1174
query77 562 266 250 250
query78 30955 49097 48547 48547
query79 15544 644 632 632
query80 4686 378 383 378
query81 572 236 236 236
query82 1095 95 95 95
query83 412 135 135 135
query84 253 68 73 68
query85 2345 287 283 283
query86 389 356 369 356
query87 3245 2990 3049 2990
query88 7112 2322 2306 2306
query89 441 272 256 256
query90 2501 206 208 206
query91 166 120 126 120
query92 69 52 49 49
query93 6126 537 551 537
query94 1580 205 201 201
query95 1136 1062 1053 1053
query96 642 326 321 321
query97 6458 6303 6362 6303
query98 201 173 178 173
query99 3737 980 901 901
Total cold run time: 340263 ms
Total hot run time: 238588 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](regex) use boost::regex instead of std:: [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30461:
URL: https://github.com/apache/doris/pull/30461#issuecomment-1913100992
TeamCity be ut coverage result:
Function Coverage: 37.84% (8034/21232)
Line Coverage: 29.54% (65464/221590)
Region Coverage: 28.96% (33620/116075)
Branch Coverage: 24.83% (17253/69488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0f5eb448c91a2689abd022c12cd733ff5d38313d_0f5eb448c91a2689abd022c12cd733ff5d38313d/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org