[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7361: API, Core, Spark:Add file groups failure in rewrite result

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7361:
URL: https://github.com/apache/iceberg/pull/7361#discussion_r1190079268


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -337,14 +337,21 @@ private Result doExecuteWithPartialProgress(
         commitManager.service(groupsPerCommit);
     commitService.start();
 
+    List<FileGroupFailureResult> rewriteFailures = Lists.newArrayList();

Review Comment:
   Race Condition here, need to use a concurrent structure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org