You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ucasfl (via GitHub)" <gi...@apache.org> on 2023/02/28 03:42:16 UTC
[GitHub] [doris] ucasfl commented on a diff in pull request #17218: [enhancement]optimize some bitmap function logic
ucasfl commented on code in PR #17218:
URL: https://github.com/apache/doris/pull/17218#discussion_r1119543918
##########
be/src/util/bitmap_value.h:
##########
@@ -1695,8 +1695,7 @@ class BitmapValue {
/**
* Return new set with specified range (not include the range_end)
*/
- int64_t sub_range(const int64_t& range_start, const int64_t& range_end,
- BitmapValue* ret_bitmap) {
+ int64_t sub_range(int64_t range_start, int64_t range_end, BitmapValue* ret_bitmap) {
Review Comment:
It's prefer `pass by value` then `pass by const reference` for basic data type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org