You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "georgthegreat (via GitHub)" <gi...@apache.org> on 2024/03/16 20:59:24 UTC

[PR] Acknowledge clang-cl when disabling compiler warnings [orc]

georgthegreat opened a new pull request, #1850:
URL: https://github.com/apache/orc/pull/1850

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1657: Acknowledge clang-cl when disabling compiler warnings [orc]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1850:
URL: https://github.com/apache/orc/pull/1850#issuecomment-2005543027

   Thanks! +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1657: Acknowledge clang-cl when disabling compiler warnings [orc]

Posted by "georgthegreat (via GitHub)" <gi...@apache.org>.
georgthegreat commented on PR #1850:
URL: https://github.com/apache/orc/pull/1850#issuecomment-2003597416

   > Thanks for the fix! Do you have access to the JIRA to create an issue for this?
   
   I have flagged ORC-1657 with the description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1657: Acknowledge clang-cl when disabling compiler warnings [orc]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1850:
URL: https://github.com/apache/orc/pull/1850#issuecomment-2005584785

   It seems that I have trouble in merging this:
   ```
   ➜  orc git:(main) ✗ ./dev/merge_orc_pr.py
   git rev-parse --abbrev-ref HEAD
   Which pull request would you like to merge? (e.g. 34): 1850
   Restoring head pointer to main
   git checkout main
   Already on 'main'
   git branch
   Traceback (most recent call last):
     File "/Users/gangwu/Projects/orc/./dev/merge_orc_pr.py", line 555, in <module>
       main()
     File "/Users/gangwu/Projects/orc/./dev/merge_orc_pr.py", line 465, in main
       modified_body = re.sub(re.compile(r"<!--[^>]*-->\n?", re.DOTALL), "", pr["body"]).lstrip()
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/re/__init__.py", line 185, in sub
       return _compile(pattern, flags).sub(repl, string, count)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   TypeError: expected string or bytes-like object, got 'NoneType'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Acknowledge clang-cl when disabling compiler warnings [orc]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1850:
URL: https://github.com/apache/orc/pull/1850#issuecomment-2002716874

   Thanks for the fix! Do you have access to the JIRA to create an issue for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1657: Acknowledge clang-cl when disabling compiler warnings [orc]

Posted by "georgthegreat (via GitHub)" <gi...@apache.org>.
georgthegreat commented on PR #1850:
URL: https://github.com/apache/orc/pull/1850#issuecomment-2006865350

   I have added PR description, it should merge now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1657: Acknowledge clang-cl when disabling compiler warnings [orc]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed pull request #1850: ORC-1657: Acknowledge clang-cl when disabling compiler warnings
URL: https://github.com/apache/orc/pull/1850


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org