[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

[GitBox <gi...@apache.org>]

anko-intel commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595481862



##########
File path: ci/jenkins/Jenkinsfile_unix_cpu
##########
@@ -37,17 +37,17 @@ core_logic: {
     custom_steps.compile_unix_cpu_openblas('cpu'),
     custom_steps.compile_unix_openblas_debug_cpu('cpu_debug'),
     custom_steps.compile_unix_mkl_cpu('cpu_mkl'),
-    custom_steps.compile_unix_mkldnn_cpu('mkldnn_cpu'),
-    custom_steps.compile_unix_mkldnn_mkl_cpu('mkldnn_mkl_cpu'),
+    custom_steps.compile_unix_onednn_cpu('mkldnn_cpu'),

Review comment:
       for me it seems that "lib_name" parameter also could be easily changed to onednn_cpu

##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -161,55 +161,55 @@ def compile_unix_mkl_cpu(lib_name) {
     }]
 }
 
-def compile_unix_mkldnn_cpu(lib_name) {
+def compile_unix_onednn_cpu(lib_name) {
     return ['CPU: MKLDNN': {
       node(NODE_LINUX_CPU) {
         ws('workspace/build-mkldnn-cpu') {

Review comment:
       Please consider renaming also workspace names




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org