You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/09/29 16:46:25 UTC
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17886
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
IMPALA-10937: Fix broken-build on Centos-7
A recent patch upgraded thrift_sasl from 0.4.2 to 0.4.3. It broke
the builds on Centos-7.
The version of setuptools which is installed by Jenkins for the
virtualenvs on Centos 7 could be lower than the requirement by
thrift_sasl 0.4.3. Another issue is the new string syntax for
install_requires in setup.py is not accepted on Centos-7.
This patch remove the requirement for setuptools in thrift_sasl's
setup.py as work around. Also change back the syntax of strings
for install_requires.
Testing:
- Ran core test on impala-private-parameterized which use Centos-7.
- Ran core test on pre-review-test which use Ubuntu.
Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
---
M shell/ext-py/thrift_sasl-0.4.3/setup.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/17886/2
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17886/3/shell/make_shell_tarball.sh
File shell/make_shell_tarball.sh:
http://gerrit.cloudera.org:8080/#/c/17886/3/shell/make_shell_tarball.sh@110
PS3, Line 110: virtualenv_tarball="${IMPALA_HOME}/infra/python/deps/virtualenv-${IMPALA_VIRTUALENV_VERSION}.tar.gz"
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 21:50:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9529/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 22:11:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
IMPALA-10937: Fix broken-build on Centos-7
A recent patch upgraded thrift_sasl from 0.4.2 to 0.4.3. It broke
the builds on Centos-7.
The version of setuptools which is installed by Jenkins for the
virtualenvs on Centos 7 could be lower than the requirement by
thrift_sasl 0.4.3. Another issue is the new string syntax for
install_requires in setup.py is not accepted on Centos-7.
This patch create a temporarily virtualenv prior to the invocation
of python in shell/make_shell_tarball.sh and install up to date
setuptools in virtualenv. Remove the virtualenv after invocation
of python code. Also change back the syntax of strings for
install_requires in setup.py for thrift_sasl 0.4.3.
Testing:
- Run core test on impala-private-parameterized which use Centos-7.
- Run core test on pre-review-test which use Ubuntu.
Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
---
M shell/ext-py/thrift_sasl-0.4.3/setup.py
M shell/make_shell_tarball.sh
2 files changed, 39 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/17886/3
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
IMPALA-10937: Fix broken-build on Centos-7
A recent patch upgraded thrift_sasl from 0.4.2 to 0.4.3. It broke
the builds on Centos-7.
The version of setuptools which is installed by Jenkins for the
virtualenvs on Centos 7 could be lower than the requirement by
thrift_sasl 0.4.3. Another issue is the new string syntax for
install_requires in setup.py is not accepted on Centos-7.
This patch create a temporarily virtualenv prior to the invocation
of python in shell/make_shell_tarball.sh and install up to date
setuptools in virtualenv. Remove the virtualenv after invocation
of python code. Also change back the syntax of strings for
install_requires in setup.py for thrift_sasl 0.4.3.
Testing:
- Run core test on impala-private-parameterized which use Centos-7.
- Run core test on pre-review-test which use Ubuntu.
Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
---
M shell/ext-py/thrift_sasl-0.4.3/setup.py
M shell/make_shell_tarball.sh
2 files changed, 38 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/17886/4
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9531/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 23:16:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
IMPALA-10937: Fix broken-build on Centos-7
A recent patch upgraded thrift_sasl from 0.4.2 to 0.4.3. It broke
the builds on Centos-7.
The version of setuptools which is installed by Jenkins for the
virtualenvs on Centos 7 could be lower than the requirement by
thrift_sasl 0.4.3. Another issue is the new string syntax for
install_requires in setup.py is not accepted on Centos-7.
This patch remove the requirement for setuptools in setup.py of
thrift_sasl as work around. Also change back the syntax of strings
for install_requires.
Testing:
- Ran core test on impala-private-parameterized which use Centos-7.
- Ran core test on pre-review-test which use Ubuntu.
Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Reviewed-on: http://gerrit.cloudera.org:8080/17886
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/ext-py/thrift_sasl-0.4.3/setup.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 05:41:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
IMPALA-10937: Fix broken-build on Centos-7
A recent patch upgraded thrift_sasl from 0.4.2 to 0.4.3. It broke
the builds on Centos-7.
The version of setuptools which is installed by Jenkins for the
virtualenvs on Centos 7 could be lower than the requirement by
thrift_sasl 0.4.3. Another issue is the new string syntax for
install_requires in setup.py is not accepted on Centos-7.
This patch remove the requirement for setuptools in setup.py of
thrift_sasl as work around. Also change back the syntax of strings
for install_requires.
Testing:
- Ran core test on impala-private-parameterized which use Centos-7.
- Ran core test on pre-review-test which use Ubuntu.
Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
---
M shell/ext-py/thrift_sasl-0.4.3/setup.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/17886/5
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7503/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 23:27:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 5: Code-Review+2
I think this makes sense as a way to get our build working.
For our purposes, the reason for upstream change (https://github.com/cloudera/thrift_sasl/issues/29) doesn't really impact our shell build, so this is a good workaround for now. We will want to get back into sync with upstream.
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 23:17:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9526/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 17:07:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10937: Fix broken-build on Centos-7
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17886 )
Change subject: IMPALA-10937: Fix broken-build on Centos-7
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9530/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c256a8ec9a151bca8b3370bfce6ecebf060bad0
Gerrit-Change-Number: 17886
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 23:00:34 +0000
Gerrit-HasComments: No