You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/25 18:48:37 UTC

[GitHub] [airflow] uranusjr commented on pull request #19830: Avoid using Proxy in subscript type alias

uranusjr commented on pull request #19830:
URL: https://github.com/apache/airflow/pull/19830#issuecomment-979421704


   On further investigation, the `Union` part is irrelevant[^1]; I can trivially trigger a crash with
   
   ```python
   import io
   import pickle
   from lazy_object_proxy import Proxy
   pickle.dump(Proxy, io.BytesIO())
   # Can't pickle <class 'Proxy'>: attribute lookup Proxy on builtins failed
   ```
   
   Next is to decide whether `lazy_object_proxy` or CPython is responsible for this.
   
   [^1]: Although Union did _trigger_ the problem for Airflow; `pickle` has no problem pickling the `lazy_object_proxy` module itself; it only fails when `Proxy` is referenced _as a type_ outside of the `lazy_object_proxy` module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org