[GitHub] [kyuubi] wForget commented on a diff in pull request #4241: Only force close engine ref when open session failed

["wForget (via GitHub)" <gi...@apache.org>]

wForget commented on code in PR #4241:
URL: https://github.com/apache/kyuubi/pull/4241#discussion_r1096879646


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -247,7 +250,7 @@ class KyuubiSessionImpl(
     try {
       if (_client != null) _client.closeSession()
     } finally {
-      if (engine != null) engine.close()
+      openSessionError.foreach { _ => if (engine != null) engine.close() }

Review Comment:
   Can we add a timeout to wait for the engine status to complete, and then kill the application.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org