[GitHub] [beam] tysonjh commented on a change in pull request #11236: [BEAM-7505] Create SideInput Python Jenkins jobs

[GitBox <gi...@apache.org>]

tysonjh commented on a change in pull request #11236:
URL: https://github.com/apache/beam/pull/11236#discussion_r422315222



##########
File path: .test-infra/jenkins/SideInputTestSuite.groovy
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Sextend(template)tware Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy extend(template) the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, sextend(template)tware
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import static LoadTestConfig.extendTemplate
+
+
+class SideInputTestSuite {
+    static def configurations = { LoadTestConfig template -> [
+        extendTemplate(template) {
+            title 'SideInput 2MB 100 byte records: global window'

Review comment:
       Changing the number of records for the main input to be 1 is fine for some of the tests but not all of them. For example, for tests that are expected to access the entire side input, if the side input is a list or iterable, then having 1 input record would be fine. We can assume that that 1 input record iterates through the entire side input.
   
   If however the side input is a dict, to simulate accessing all the side input records, the main input and side input should have the same number of records.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org