[GitHub] [spark] ueshin commented on pull request #36547: [SPARK-39197][PYTHON] Implement `skipna` parameter of `GroupBy.all`

[GitBox <gi...@apache.org>]

ueshin commented on PR #36547:
URL: https://github.com/apache/spark/pull/36547#issuecomment-1128165133

   I'm afraid I'm not sure the point here.
   
   I don't think methods affect the builtin functions:
   
   ```py
   >>> class A:
   ...   def all(self):
   ...     print("all")
   ...
   >>>
   >>> A().all()
   all
   >>> all
   <built-in function all>
   >>> all()
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   TypeError: all() takes exactly one argument (0 given)
   >>> all([True])
   True
   >>> all([False])
   False
   ```
   
   Also I'm not sure how `@final` helps to avoid shading issue.
   
   Btw, 
   
   > The PEP targets Python 3.8 so it seems fine to introduce it to the master branch.
   
   We are still supporting Python 3.7. 
   
   https://github.com/apache/spark/blob/47d237c74ccb1836e3de82dc583499ffd3f25755/python/setup.py#L276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org