You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/04 12:05:33 UTC
[GitHub] EugeneYushin commented on a change in pull request #6760:
[FLINK-10422] Follow AWS specs in Kinesis Consumer
EugeneYushin commented on a change in pull request #6760: [FLINK-10422] Follow AWS specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r253443826
##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName, @Nullable String startSha
}
}
}
- // Kinesalite (mock implementation of Kinesis) does not correctly exclude shards before
Review comment:
@tweise I've updated PR by putting logic to compare shardIds back. The only difference is I compare it lexicographically. I've added [unit test](https://github.com/apache/flink/pull/6760/files#diff-ca964572c13e36273275e10203360684) to prove it works as expected with Kinesis/Kinesalite shard id's format.
I've resolved conflicts as requested as well.
Can you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services