You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/08/11 09:51:40 UTC

[GitHub] flink pull request #4528: [FLINK-7427][network] integrate PartitionRequestPr...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4528

    [FLINK-7427][network] integrate PartitionRequestProtocol into NettyProtocol

    ## What is the purpose of the change
    
    This is to make the network protocol classes more understandable by removing one unnecessary level of abstraction.
    
    ## Brief change log
    
    - integrate `PartitionRequestProtocol` into `NettyProtocol`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup covered by existing network tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (code-path yes, performance no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (JavaDocs)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7427

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4528
    
----
commit 1c0e5aae05f3e4eaec986792b508a08ee242ac73
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-08-10T14:58:19Z

    [FLINK-7427][network] integrate PartitionRequestProtocol into NettyProtocol
    
    - removes one level of (unneeded) abstraction for clarity

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4528: [FLINK-7427][network] integrate PartitionRequestPr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4528


---