You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spark.apache.org by Nan Zhu <zh...@gmail.com> on 2014/03/03 16:38:44 UTC

[SUGGESTION] suggest contributors to run sbt scalastyle before run sbt test

Hi, all

I noticed this because…my two PRs failed for the style error (exceeding for 3 - 5 chars) yesterday

Maybe we can explicitly suggest contributors to run sbt scalastyle before they run test cases  

https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

Just add one sentence after 4 is good enough, I think  

Best,  

--  
Nan Zhu

Re: [SUGGESTION] suggest contributors to run sbt scalastyle before run sbt test

Posted by Reynold Xin <rx...@databricks.com>.

Thanks for the suggestion. Just did it.


On Mon, Mar 3, 2014 at 7:38 AM, Nan Zhu <zh...@gmail.com> wrote:

> Hi, all
>
> I noticed this because...my two PRs failed for the style error (exceeding
> for 3 - 5 chars) yesterday
>
> Maybe we can explicitly suggest contributors to run sbt scalastyle before
> they run test cases
>
> https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
>
> Just add one sentence after 4 is good enough, I think
>
> Best,
>
> --
> Nan Zhu
>
>