You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/07 19:12:11 UTC

[kudu-CR] [build] fix on ld's -l:path to file notation on OS X 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9242


Change subject: [build] fix on ld's -l:path_to_file notation on OS X
......................................................................

[build] fix on ld's -l:path_to_file notation on OS X

Fixed the sized-deallocation test on OS X.

The -l:<path_to_library> works fine with Linux linker, but this notation
is not supported by ld on OS X.  I didn't notice that because I built
on OS X with OUTPUT_QUIET and ERROR_QUIET options already set
for execute_process(), after verifying that it works as need at Linux.

Now, for Kudu builds on OS X 10.12.x and higher the sized deallocation
is enabled, and on OS X 10.11.x it's disabled.

This is a follow-up for c1b9f1088f830235f9d4e6830f59b1a200a65ab6.

Change-Id: I65304c2d7c37abdddb8c60eac0e288b546cfc530
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/9242/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65304c2d7c37abdddb8c60eac0e288b546cfc530
Gerrit-Change-Number: 9242
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [build] fix on ld's -l:path to file notation on OS X

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9242 )

Change subject: [build] fix on ld's -l:path_to_file notation on OS X
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65304c2d7c37abdddb8c60eac0e288b546cfc530
Gerrit-Change-Number: 9242
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:58:36 +0000
Gerrit-HasComments: No

[kudu-CR] [build] fix on ld's -l:path to file notation on OS X

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9242 )

Change subject: [build] fix on ld's -l:path_to_file notation on OS X
......................................................................

[build] fix on ld's -l:path_to_file notation on OS X

Fixed the sized-deallocation test on OS X.

The -l:<path_to_library> works fine with Linux linker, but this notation
is not supported by ld on OS X.  I didn't notice that because I built
on OS X with OUTPUT_QUIET and ERROR_QUIET options already set
for execute_process(), after verifying that it works as need at Linux.

Now, for Kudu builds on OS X 10.12.x and higher the sized deallocation
is enabled, and on OS X 10.11.x it's disabled.

This is a follow-up for c1b9f1088f830235f9d4e6830f59b1a200a65ab6.

Change-Id: I65304c2d7c37abdddb8c60eac0e288b546cfc530
Reviewed-on: http://gerrit.cloudera.org:8080/9242
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65304c2d7c37abdddb8c60eac0e288b546cfc530
Gerrit-Change-Number: 9242
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>